[Spice-devel] [NSIS] packaging: add Makefile, spec file, jenkins automation

[Yedidyah Bar David]

On Wed, Oct 21, 2015 at 7:43 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Oct 21, 2015 at 05:47:12PM +0300, Yedidyah Bar David wrote:
>> Allow 'make dist'.
>>
>> Allow building the spice installer and building/installing the ovirt
>> installer.
>>
>> VERSION moved from the nsis file to the Makefile and will be maintained
>> there.
>>
>> Some Makefile variables (format: PARAM (valid values) [default]):
>> MODE (SPICE,OVIRT) [SPICE] - its value is passed as a define to makensis
>> DISPLAYED_VERSION () [$VERSION] - what's written to the registry
>> INSTALLER () [depends on MODE] - installer filename without .exe ext
>> UNINSTALLER () [depends on MODE] - uninstaller filename without .exe ext
>>
>> Some of the code in the Makefile was copied and adapted from
>> ovirt-wgt-installer.spec. The spec file itself was also copied here and
>> adapted, and will be removed [1] from its current location.
>>
>> Add jenkins.ovirt.org automation.
>>
>> Change all /usr/share/artifacts to /usr/share.
>>
>> See also:
>>
>> https://gerrit.ovirt.org/45833 - spice-nsis aka ovirt-wgt
>> https://gerrit.ovirt.org/47460 - ovirt-wgt-toolchain
>> https://gerrit.ovirt.org/47461 - ovirt-guest-agent
>>
>> [1] https://gerrit.ovirt.org/47432
>>
>> Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22
>> Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
>> Signed-off-by: Yedidyah Bar David <didi at redhat.com>
>> ---
>
> For what it's worth, I'd split this change in separate commits:

I agree about most, not sure I see much point though. It's not that
reviewing them separately is much less work. I might be wrong :-)

>
>>  Makefile                            | 100 ++++++++++++++++++++++++++++++++++++
>
> one adding the Makefile
>
>>  automation/README.md                |   8 +++
>>  automation/build-artifacts.packages |  10 ++++
>>  automation/build-artifacts.repos    |   2 +
>>  automation/build-artifacts.sh       |  21 ++++++++
>>  automation/check-patch.packages     |  10 ++++
>>  automation/check-patch.repos        |   2 +
>>  automation/check-patch.sh           |  21 ++++++++
>
> one adding the automation bits
>
>>  ovirt-wgt-installer.spec            |  63 +++++++++++++++++++++++
>
> one adding the spec file
>
>>  win-guest-tools.nsis                |  31 +++++++----
>
> and one adding the *VERSION variables

Not sure about this one.

I move here the maintenance of VERSION from the nsis file
to Makefile.

If you really want to split them to two changes, I have to
carefully create a minimal Makefile just allowing this.

I probably already did at one point, can check previous versions of
the change in gerrit.

Is it really that important?

>
> Christophe



-- 
Didi