[Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

[Lev Veyde]

Hi Christophe,

Yes, that's the reason.

I don't see any reason to hide the fact that we use another open source project (NSIS) to produce the installer, even if it provides that option.
Unless of course, we absolutely must use the window space real-estate for something else, and note that fact somewhere else.

Thanks in advance,
Lev Veyde.

----- Original Message -----
From: "Yedidyah Bar David" <didi at redhat.com>
To: "Christophe Fergeau" <cfergeau at redhat.com>
Cc: spice-devel at lists.freedesktop.org, "Lev Veyde" <lveyde at redhat.com>
Sent: Thursday, October 22, 2015 8:28:15 AM
Subject: Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

On Wed, Oct 21, 2015 at 7:50 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> Sorry if I missed it/forgot the answer

You didn't :-)

You already asked and I replied asking Lev.

> , but why do we need/want this
> change?

I guess it's mainly to pay tribute to that project.

Lev?

You already merged it to your own branch [1] so I thought that's not
questionable.

[1] http://cgit.freedesktop.org/~teuf/spice-nsis/log/?h=ovirt

>
> Christophe
>
> On Tue, Oct 20, 2015 at 02:35:24PM +0300, Yedidyah Bar David wrote:
>> From: Lev Veyde <lveyde at redhat.com>
>>
>> Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a
>> Signed-off-by: Lev Veyde <lveyde at redhat.com>
>> ---
>>  win-guest-tools.nsis | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
>> index efd7392..a6e14de 100644
>> --- a/win-guest-tools.nsis
>> +++ b/win-guest-tools.nsis
>> @@ -61,7 +61,7 @@ Name "${NAME}"
>>  Caption "${NAME} Installer"
>>  OutFile "${FILENAME}-${VERSION}.exe"
>>  InstallDir "$PROGRAMFILES\${NAME}"
>> -BrandingText " "
>> +BrandingText ""
>>
>>  # SilentInstall silent
>>  ShowInstDetails nevershow
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Didi