[Spice-devel] [PATCH spice-gtk 1/3] MainChannel: move task free from finalize to dispose

[Victor Toso]

Hi,

On Thu, Oct 22, 2015 at 10:06:04AM +0200, Fabiano Fidêncio wrote:
> On Thu, Oct 22, 2015 at 9:13 AM, Victor Toso <lists at victortoso.com> wrote:
> > Hi,
> >
> > On Wed, Oct 21, 2015 at 03:52:49PM -0500, Jonathon Jongsma wrote:
> >> +    if (c->file_xfer_tasks) {
> >> +        g_hash_table_unref(c->file_xfer_tasks);
> >> +        c->file_xfer_tasks = NULL;
> >> +    }
> >> +
> >
> > g_clear_object(&c->file_xfer_tasks);
>
> No, please, it's wrong.
> For GHashTable you must use g_clear_pointer() instead of
> g_clear_object() and g_clear_pointer() is part of GLib since 2.34,
> while we depend on 2.28.

g_clear_object is 2.28, I checked in the manual before saying, just to
be sure:

https://developer.gnome.org/gobject/unstable/gobject-The-Base-Object-Type.html#g-clear-object