[Spice-devel] [PATCH 04/14] server: start separate display/cursor channel headers

[Fabiano Fidêncio]

On Fri, Oct 23, 2015 at 3:54 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>
>>
>> On Fri, Oct 23, 2015 at 3:25 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>> >
>> >>
>> >> From: Marc-André Lureau <marcandre.lureau at gmail.com>
>> >>
>> >> Just move some declarations around
>> >> ---
>> >>  server/Makefile.am       |   2 +
>> >>  server/cursor_channel.h  |  62 +++++++++++
>> >>  server/display-channel.h | 211 +++++++++++++++++++++++++++++++++++++
>> >>  server/red_worker.c      | 264
>> >>  +----------------------------------------------
>> >>  server/red_worker.h      |  20 ++++
>> >>  5 files changed, 297 insertions(+), 262 deletions(-)
>> >>  create mode 100644 server/cursor_channel.h
>> >>  create mode 100644 server/display-channel.h
>> >>
>> >> diff --git a/server/Makefile.am b/server/Makefile.am
>> >> index cd4686a..a701170 100644
>> >> --- a/server/Makefile.am
>> >> +++ b/server/Makefile.am
>> >> @@ -106,6 +106,8 @@ libspice_server_la_SOURCES =                      \
>> >>       red_time.h                              \
>> >>       red_worker.c                            \
>> >>       red_worker.h                            \
>> >> +     display-channel.h                       \
>> >> +     cursor_channel.h                        \
>> >
>> > I think this file should cursor-channel.h as renamed some patches later
>>
>> Good catch, but here I have to disagree.
>> I would not start having two "nomenclatures" for files at this point.
>> The most part of the files are using "_" instead of "-". I would go
>> for "_" for all of them, including display-channel. :-)
>>
>
> This is part of the refactory. The big rename patch was removed just temporarily
> to make it easier for cherry picking and similar but new files should have dash
> and old files will be renamed later.

Okay, makes sense.

>
> Frediano