[Spice-devel] [PATCH 4/5] server: move some pixmap cache code in own file

[Christophe Fergeau]

On Fri, Oct 16, 2015 at 07:57:43AM -0400, Frediano Ziglio wrote:
> Looks good to me beside one things, some structure was renamed with underscore
> prefix while the typedef did not have the prefix, specifically:
> 
> struct NewCacheItem -> struct _NewCacheItem
> struct PixmapCache -> struct _PixmapCache
> struct DisplayChannelClient -> struct _DisplayChannelClient
> 
> I don't like this change and also it's against C99 standards (an id starting with
> underscore and capital case is a reserved id).

For what it's worth, this is fairly typical in glib and in libraries
using glib. It's indeed theoritically reserved in the C99 standard, but
I suspect nothing is going to happen to this kind of usage.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151023/9a675860/attachment.sig>