[Spice-devel] [PATCH 5/9] server: dispatcher_init/dispatcher_new

[Christophe Fergeau]

On Thu, Oct 22, 2015 at 09:51:09AM -0400, Frediano Ziglio wrote:
> QXLState has just two fields (qif and dispatcher) and is mainly used to bind
> QXLInstance and RedDispatcher. The qif field is used mainly (only once in reds.c) in
> red_worker.c and red_dispatcher.c. Usually you start with a pointer to QXLInstance so
> the path to discover QXLInterface is qxl->st->qif while using qxl->base.sif
> (converting it to QXLInterface) is faster.
> IMHO RedDispatcher is the private implementation of a QXLInstance object hidden
> but all these pointers. For instance RedDispatcher build and manage the worker.

I think I reached a similar conclusion at some point, I have an old
branch doing some renaming with one commit saying
« RedDispatcher is mostly some private data added on top of QXLWorker,
  it's less confusing to merge both and get rid of RedDispatcher
  (especially when there's also a class called Dispatcher). »

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151023/ea925814/attachment.sig>