[Spice-devel] [spice-server] build-sys: Adjust to new spice-common spice-deps.m4

[Fabiano Fidêncio]

On Mon, Oct 26, 2015 at 2:11 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Oct 26, 2015 at 10:59:08AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 10/26/2015 10:55 AM, Christophe Fergeau wrote:
>> > On Mon, Oct 26, 2015 at 10:49:47AM -0200, Eduardo Lima (Etrunko) wrote:
>> >> On 10/23/2015 10:19 AM, Christophe Fergeau wrote:
>> >>> This commit also updates the spice-common submodule
>> >>>
>> >>> Christophe Fergeau (7):
>> >>>       Add marshaller test case
>> >>>       build-sys: Use ${PKG_CONFIG} rather than pkg-config
>> >>>       build-sys: Rework SPICE_CHECK_* m4 macros
>> >>>       build-sys: Add gio-2.0 to SPICE_CHECK_GLIB2
>> >>>       build-sys: Fix error in SPICE_CHECK_LZ4 description
>> >>>       build-sys: Set automake conditional in SPICE_CHECK_SMARTCARD
>> >>>       build-sys: Rename SUPPORT_GL to HAVE_GL
>> >>>
>> >>> Javier Celaya (1):
>> >>>       Fix linearization of several marshallers with one item
>> >>>
>> >>> Lukas Venhoda (3):
>> >>>       ssl-verify: Only check addr length when using IP addr
>> >>>       m4: Require glib version >= 2.22
>> >>>       ssl-verify: Changed IPv4 hostname to IPv6
>> >>
>> >> Is the message correct for this commit? Or it is some leftover from
>> >> other patch series?
>> >>
>> >
>> > For submodule updates, I add the shortlog between the old submodule
>> > revision and the new one. I can stop doing this if this is too
>> > confusing/not useful, or add some description before pasting it.
>> >
>>
>> Alright, I did not know about this policy of updating the submodule, and
>> yes, as a newcomer, I found it a bit confusing.
>
> I would not call that a policy, just something I do (I'm probably the
> only one doing that here). Is it enough if I just add a
> "git shortlog of the spice-common submodule changes:" before the
> shortlog? Or should I just drop this?

I like the way you have done this.
I would like to see, at least, a reason for why we are updating the submodule.

>
> Christophe
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>

Best Regards,