[Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

[Christophe Fergeau]

Hey,

On Mon, Oct 26, 2015 at 05:24:07PM +0200, Yedidyah Bar David wrote:
> On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote:
> >> Allow passing:
> >>
> >> DISPLAYED_VERSION (defaults to $VERSION): what's written to the
> >> registry. This is what is shown to the user e.g. in the control panel.
> >>
> >> EXE_VERSION (defaults to -$VERSION): appended to installer filename.
> >
> > Why do we want 2 different versions in addition to $VERSION? Can't the
> > same version number be used in the registry and in the installer
> > filename?
> 
> Currently:
> 
> VERSION is 0.103
> 
> spice wants the installer to be named spice-guest-tools-0.103.exe and
> show in the control panel "version: 0.103"
> 
> ovirt wants the installer to be named ovirt-guest-tools-setup.exe and
> show in the control panel (for automatic jenkins builds, at least):
> "version: 3.6.0-0.2_master.DATE.gitHASH"

Ah ok, thanks for the example, so the point of EXE_VERSION is so that you
can _remove_ the version from the .exe file for the oVirt installer.

> If you want a different implementation please explain clearly how it should
> look/work.

So far, I was not asking for a different implementation, I was really
asking for the meaning of the 2 variables, since I did not understand
what they were for ;)

I think I'd either go with a bit of magic: if DISPLAYED_VERSION is set,
then don't append version to .exe file, or with some ifdef OVIRT/SPICE
for the exe name (always append for SPICE, don't append for OVIRT).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151026/c68ffea3/attachment.sig>