[Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

[Frediano Ziglio]

> 
> From: Marc-André Lureau <marcandre.lureau at gmail.com>
> 
> ---
>  server/red_worker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index c027fde..3aa05d8 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -9802,7 +9802,7 @@ static void guest_set_client_capabilities(RedWorker
> *worker)
>      DisplayChannelClient *dcc;
>      RedChannelClient *rcc;
>      RingItem *link, *next;
> -    uint8_t caps[58] = { 0 };
> +    uint8_t caps[58] = { 0 }; /* FIXME: 58?? */
>      int caps_available[] = {
>          SPICE_DISPLAY_CAP_SIZED_STREAM,
>          SPICE_DISPLAY_CAP_MONITORS_CONFIG,
> --
> 2.4.3
> 

I think the reply came from http://cgit.freedesktop.org/spice/spice-protocol/commit/?id=361fd166b26b4450617b1f7175be9aaa7d8f6a7e
The "fix" would require a change (a definition) in spice-protocol spice/qxl_dev.h file and use the mnemonic instead.

Or we could use instead a sizeof(((QXLRom*)0)->client_capabilities).

Personally I would prefer the second, we just released a spice-protocol release so doing the change,
bumping version and update version on spice-server is quite long.

Frediano