[Spice-devel] [PATCH] replay: compatibility with former version

[Christophe Fergeau]

On Tue, Sep 01, 2015 at 12:09:23PM -0400, Frediano Ziglio wrote:
> > 
> > On Tue, Sep 01, 2015 at 03:18:37PM +0100, Frediano Ziglio wrote:
> > > GMutex usage in replay.c was not working so replace with plain pthread.
> > > Avoid to use typedef twice for the same type.
> > 
> > Looks like the logs for 2 different commits stuck together in a single
> > commit ;)
> > 
> 
> I can split it.
> > 
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  server/tests/basic_event_loop.c |  8 ++++----
> > >  server/tests/replay.c           | 11 ++++++-----
> > >  2 files changed, 10 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/server/tests/basic_event_loop.c
> > > b/server/tests/basic_event_loop.c
> > > index e692f3a..89e05ad 100644
> > > --- a/server/tests/basic_event_loop.c
> > > +++ b/server/tests/basic_event_loop.c
> > > @@ -22,11 +22,11 @@ int debug = 0;
> > >  #define NOT_IMPLEMENTED printf("%s not implemented\n", __func__);
> > >  
> > >  
> > > -typedef struct SpiceTimer {
> > > +struct SpiceTimer {
> > >      SpiceTimerFunc func;
> > >      void *opaque;
> > >      guint source_id;
> > > -} SpiceTimer;
> > > +};
> > 
> > In my opinion, it would be less confusing to give it a different name
> > than SpiceTimer since it's already used
> > 
> 
> I think the intention of the header is to define an abstract structure
> that shold be implemented by some code. The server/tests/basic_event_loop.c
> implemented it defining the real structure.

Ah right, forgot about that. ACK then.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150902/5cc235d9/attachment.sig>