[Spice-devel] [PATCH v2 2/2] Don't send monitors config when Display widget is created

[Jonathon Jongsma]

Oops, overlooked Pavel's earlier review. Sorry.


On Tue, 2015-08-18 at 14:59 +0200, Pavel Grunt wrote:
> Hi Jonathon,
> looks good, just one question below.


.....

> > @@ -226,6 +239,16 @@ static void update_ready(SpiceDisplay *display)
> >  
> >      ready = d->mark != 0 && d->monitor_ready;
> >  
> > +    /* If the 'resize-guest' property is set, the application expects spice
> > -gtk
> > +     * to manage the size and state of the displays, so update the 'enabled'
> > +     * state here. If 'resize-guest' is false, we can assume that the
> > +     * application will manage the state of the displays.
> > +     */
> > +    if (d->resize_guest_enable) {
> > +        spice_main_update_display_enabled(d->main, get_display_id(display),
> > +                                          ready, FALSE);
> Shouldn't 'update' be TRUE if the app expects spice-gtk to handle the state of
> the display?


Indeed. thanks. I'll send a new version with this change.