[Spice-devel] [PATCH] build-sys: Update warning message

[Christophe Fergeau]

On Mon, Sep 07, 2015 at 09:20:45AM -0400, Frediano Ziglio wrote:
> Even better:
> 
> From: Frediano Ziglio <fziglio at redhat.com>
> Date: Fri, 4 Sep 2015 11:22:01 +0100
> Subject: [PATCH] build-sys: Update warning message
> 
> arch_warn was set to 1 only if architecture is not x86, x64 or arm.
> Update the message as we actually main test x64.

'mainly test'

> Also change the way message is saved so it easier to spot wrong
> message changing the part that check for architecture (previously
> there was one section of script to check and one with the message).

I'd word this like "Define the warning message and do the architecture
checks in the same place so that they are easier to keep in sync"

ACK.

Christophe

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  configure.ac | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index dee0a28..61f8dcd 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -63,10 +63,11 @@ m4_ifndef([AS_VAR_APPEND],
>  
>  # Check for the CPU we are using
>  case $host_cpu in
> -  i386|i486|i586|i686|i786|k6|k7|x86_64|armv6|armv6l|armv6hl|armv7|armv7l|armv7hl)
> +  x86_64)
> +        arch_warn=""
>          ;;
>    *)
> -        arch_warn=1
> +        arch_warn="spice-server on non-x86_64 architectures hasn't been extensively tested"
>  esac
>  
>  dnl =========================================================================
> @@ -322,8 +323,8 @@ echo "
>          Manual:                   ${have_asciidoc}
>  "
>  
> -if test x"$arch_warn" = x1; then
> -        AC_MSG_WARN([spice-server on non-x86/x86_64 architectures hasn't been extensively tested])
> +if test x"$arch_warn" != x; then
> +        AC_MSG_WARN([$arch_warn])
>          echo ""
>  fi
>  
> -- 
> 2.4.3
> 
> > 
> > Saying that spice-server has been tested 'extensively' on x86 is not
> > really true imo, even less so for arm. I'd go with:
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 1903384..9208b09 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -63,7 +63,7 @@ m4_ifndef([AS_VAR_APPEND],
> > 
> >  # Check for the CPU we are using
> >  case $host_cpu in
> > -
> > i386|i486|i586|i686|i786|k6|k7|x86_64|armv6|armv6l|armv6hl|armv7|armv7l|armv7hl)
> > +  x86_64)
> >          ;;
> >    *)
> >          arch_warn=1
> > @@ -323,7 +323,7 @@ echo "
> >  "
> > 
> >  if test x"$arch_warn" = x1; then
> > -        AC_MSG_WARN([spice-server on non-x86/x86_64 architectures hasn't
> > been extensively tested])
> > +        AC_MSG_WARN([spice-server on non-x86_64 architectures hasn't been
> > extensively tested])
> >          echo ""
> >  fi
> > 
> > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150907/cff392b9/attachment.sig>