[Spice-devel] [PATCH spice-html5 4/5] Use name of channel instead of number

[Pavel Grunt]

Hi Uri,

On Tue, 2015-09-08 at 12:44 +0300, Uri Lublin wrote:
> Hi Pavel,
> 
> I'd add to the log message that for unknown types the type-number is 
> still printed.
> 
sure, I updated the log message

Thank you,
Pavel

> Regards,
>      Uri.
> 
> On 09/07/2015 05:38 PM, Pavel Grunt wrote:
> > ---
> >   main.js      | 2 +-
> >   spiceconn.js | 4 ++--
> >   2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/main.js b/main.js
> > index 99b2274..be8ad2e 100644
> > --- a/main.js
> > +++ b/main.js
> > @@ -138,10 +138,10 @@ SpiceMainConn.prototype.process_channel_message =
> > function(msg)
> >                   this.cursor = new SpicePlaybackConn(conn);
> >               else
> >               {
> > -                this.log_err("Channel type " + chans.channels[i].type + "
> > unknown.");
> >                   if (! ("extra_channels" in this))
> >                       this.extra_channels = [];
> >                   this.extra_channels[i] = new SpiceConn(conn);
> > +                this.log_err("Channel type " +
> > this.extra_channels[i].channel_type() + " not implemented");
> >               }
> > 
> >           }
> > diff --git a/spiceconn.js b/spiceconn.js
> > index 70437be..903f3b0 100644
> > --- a/spiceconn.js
> > +++ b/spiceconn.js
> > @@ -342,10 +342,10 @@ SpiceConn.prototype =
> >               {
> >                   rc = this.process_channel_message(msg);
> >                   if (! rc)
> > -                    this.log_warn(this.type + ": Unknown message type " +
> > msg.type + "!");
> > +                    this.log_warn(this.channel_type() + ": Unknown message
> > type " + msg.type + "!");
> >               }
> >               else
> > -                this.log_err(this.type + ": No message handlers for this
> > channel; message " + msg.type);
> > +                this.log_err(this.channel_type() + ": No message handlers
> > for this channel; message " + msg.type);
> >           }
> > 
> >           if (this.msgs_until_ack !== undefined && this.ack_window)
> > 
>