[Spice-devel] [NSIS 8/8] packaging: add Makefile

[Sandro Bonazzola]

On Thu, Sep 10, 2015 at 3:25 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote:
> > From: Sandro Bonazzola <sbonazzo at redhat.com>
> >
> > Allow to generate the tar.gz by just calling
> > "make ovirt-dist"
> >
> > Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22
> > Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
> > Signed-off-by: Yedidyah Bar David <didi at redhat.com>
> > ---
> >  Makefile | 5 +++++
> >  1 file changed, 5 insertions(+)
> >  create mode 100644 Makefile
> >
> > diff --git a/Makefile b/Makefile
> > new file mode 100644
> > index 0000000..0a7afda
> > --- /dev/null
> > +++ b/Makefile
> > @@ -0,0 +1,5 @@
> > +OVIRT_WGT_VERSION="3.6.0"
> > +
> > +ovirt-dist:
> > +     tar -c --transform 's,^\.,ovirt-wgt,' --exclude=.git
> --exclude=ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz . | \
> > +     GZIP=$(GZIP_ENV) gzip -c > ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz
>
> Looks like 'git archive --prefix ovirt-wgt-${OVIRT_WGT_VERSION}
> --format=tar | gzip -c > ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz
>

If you tar xz the generated tarball and then try to run again make dist it
will fail missing the .git directory.
I'd prefer to avoid having a make dist not working on extracted sources.
ovirt-dist is because of the ovirt version involved in tarball name. Not
sure that out of ovirt such version make sense.




>
> I don't think there is anything oVirt specific in the generated tarball
> though, this could be a generic 'make dist' upstream target.
>
> Christophe
>



-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150910/9bca0444/attachment.html>