[Spice-devel] [PATCH] display: Advertise preferrred compression cap

[Pavel Grunt]

Hi Christophe,

On Tue, 2015-09-15 at 18:08 +0200, Christophe Fergeau wrote:
> The patches adding a way for the client to set its preferred compression
> method added a new capability so that the server can indicate support
> for this feature. However, spice-server was not setting this capability
> on its display channel, which means clients are not going to try to send
> 'preferred-compression' messages even though the user request it.
> ---
>  server/red_worker.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index e2feb23..0b22f0d 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -10520,6 +10520,7 @@ static RedChannel *__new_channel(RedWorker *worker,
> int size, uint32_t channel_t
>                                          handle_parsed,
>                                          &channel_cbs,
>                                          migration_flags);
> +    red_channel_set_cap(channel, SPICE_DISPLAY_CAP_PREF_COMPRESSION);

Why is it not set in server/red_dispatcher.c, with other display channel caps ?

Pavel
>      common = (CommonChannel *)channel;
>      if (!channel) {
>          goto error;