[Spice-devel] [spice-gtk]Add "monitors config position" capability.

[Sandy Stutsman]

The distinction is between multi-hat where a single instance of the graphics driver handles multiple monitors and, say, the windows driver where there is a separate driver instance for each monitor.

----- Original Message -----
> From: "Marc-André Lureau" <mlureau at redhat.com>
> To: "Sandy Stutsman" <sstutsma at redhat.com>
> Cc: spice-devel at lists.freedesktop.org
> Sent: Tuesday, September 15, 2015 6:21:14 PM
> Subject: Re: [Spice-devel] [spice-gtk]Add "monitors config position" capability.
> 
> Hi
> 
> ----- Original Message -----
> > This will allow Windows guests to determine if the client supports a
> > monitors_config message from a multi-monitor guest that is not
> > multi-hat.
> > 
> 
> multi-hat?
> 
> > It keeps commit:8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d
> > from breaking if an updated win-qxl driver is paired with an older client.
> > 
> > This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248189
> > ---
> > Changed from v1: Removed a local commit that preceded this one.
> > ---
> > Changed from v2: Changed name to "monitors config position"
> > ---
> >  src/channel-main.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/channel-main.c b/src/channel-main.c
> > index 03e407e..2ec6457 100644
> > --- a/src/channel-main.c
> > +++ b/src/channel-main.c
> > @@ -215,6 +215,7 @@ static const char *agent_caps[] = {
> >      [ VD_AGENT_CAP_GUEST_LINEEND_CRLF  ] = "line-end crlf",
> >      [ VD_AGENT_CAP_MAX_CLIPBOARD       ] = "max-clipboard",
> >      [ VD_AGENT_CAP_AUDIO_VOLUME_SYNC   ] = "volume-sync",
> > +    [ VD_AGENT_CAP_MONITORS_CONFIG_POSITION ] = "monitors config
> > position",
> >  };
> >  #define NAME(_a, _i) ((_i) < SPICE_N_ELEMENTS(_a) ? (_a[(_i)] ?: "?") :
> >  "?")
> >  
> > @@ -1279,6 +1280,7 @@ static void agent_announce_caps(SpiceMainChannel
> > *channel)
> >      VD_AGENT_SET_CAPABILITY(caps->caps, VD_AGENT_CAP_DISPLAY_CONFIG);
> >      VD_AGENT_SET_CAPABILITY(caps->caps, VD_AGENT_CAP_CLIPBOARD_BY_DEMAND);
> >      VD_AGENT_SET_CAPABILITY(caps->caps, VD_AGENT_CAP_CLIPBOARD_SELECTION);
> > +    VD_AGENT_SET_CAPABILITY(caps->caps,
> > VD_AGENT_CAP_MONITORS_CONFIG_POSITION);
> >  
> >      agent_msg_queue(channel, VD_AGENT_ANNOUNCE_CAPABILITIES, size, caps);
> >      g_free(caps);
> > --
> > 1.9.5.msysgit.0
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> > 
>