[Spice-devel] [PATCH v4 00/16] Make start and stop usb redirection asynchronous

[Christophe Fergeau]

On Tue, Sep 08, 2015 at 08:42:00PM +0300, Dmitry Fleytman wrote:
> > This patchs series makes start/stop USB redirection flows run in their own threads.
> > It solves spice-gtk freeze problems since start and stop redirection are time consuming operations.
> > This series include new api exposure, threads syncronization and new usb redirection widget behavior.
> > When redirection starts/ends widget will turn inactive/active.

There are still no commit log with any indication explaining why we want
to make things asynchronous. This blocking should be mentioned
somewhere, as well as the exact usbredir/libusb method which is
blocking. If I remember correctly, it's libusb_open() in
spice_usbredir_channel_open_device which can be blocking when usbdk is
used (any more specific way to hit this issue?), but this really needs
to be very well explained in one of the commit logs.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150922/8af0c2ce/attachment-0001.sig>