[Spice-devel] [RFC PATCH] [linux-vdagent] Lock screen on disconnect

[David Mansfield]

Hi,

The attached is a very simple patch, which is working but possibly not 
suitable for inclusion at this point, that locks the x11 session when 
the client disconnects.

Locking is performed using "xdg-screensaver lock", which seems like an 
ok implementation given that "xdg-open" is used in the file-transfer code.

I looked at the ovirt-guest-agent code and that agent also locks the 
session on disconnect unless specifically disabled.

Citrix (ICAClient) sessions also automatically lock when the client 
disconnects.

Other thoughts:

1) Should text consoles be considered? (me: NO)

2) Does GDM need any special exception? (me: needs to be tested)

3) Is there any point checking the exit status of the lock command? (me: NO)

4) Should the lock command be configurable? (me: grumble)

5) Should the lock-on-disconnect be optional and what default value? 
(me: default: lock)

6) If lock-on-disconnect is optional, how to configure? (me: Because the 
process we care about is running in a specific user session, 
configuration may be left to the user, and so possibly 
~/.spice-vdagent.conf).  Note: there are other options to spice-vdagent 
that I can't see how anyone would be able to control using configuration 
files.

7) Windows agent feature parity?

-- 
Thanks,
David Mansfield
Cobite, INC.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: spice-vdagent-lock-on-disconnect.patch
Type: text/x-patch
Size: 816 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150923/5f6f02d5/attachment-0001.bin>