[Spice-devel] [PATCH spice-gtk 2/2] Don't include super-header from channel-main.h

[Marc-André Lureau]

----- Original Message -----
> On Tue, 2015-09-22 at 11:40 -0400, Marc-André Lureau wrote:
> > Hi
> > 
> > ----- Original Message -----
> > > 
> > > 
> > > ----- Original Message -----
> > > > On Tue, 2015-09-22 at 11:30 -0400, Marc-André Lureau wrote:
> > > > > 
> > > > > ----- Original Message -----
> > > > > > Does anybody object to this series?
> > > > > 
> > > > > Yes, you broke the build with 1/2 and then you fix it in 2/2? and you
> > > > > didn't explain what the point of it.
> > > > 
> > > > The point of it? channel-main.c should include channel-main.h. The fact
> > > > that it was indirectly included was only an accident. I thought that
> > > > would be self-explanatory. As for combining the two, that's a good
> > > > point. Are you ok with it if I squash these?
> > > 
> > > Hmm, this could potentially break build of other users, since
> > > spice-client.h
> > > is no longer included by channel-main.h.
> > > 
> > > Instead, I would suggest to add internal header guards, so only
> > > spice-client.h can be included, and you get a compiler warning if not
> > > (see
> > > how it's done with glib for ex)
> > 
> > spice-widget.h and documentation will need to be updated too.
> 
> spice-client.h only includes the non-gtk headers. So spice-widget.h is
> not included there (nor is spice-gtk-session.h, etc). So I don't think
> anything needs to change there. What did you have in mind?

The same as spice-client.h: have a single top-level header.

spice-gtk has the following headers:
spice-grabsequence.h
spice-gtk-session.h
spice-widget-enums.h
spice-widget.h
usb-device-widget.h