[Spice-devel] [PATCH spice-gtk 2/2] Don't include super-header from channel-main.h

[Marc-André Lureau]

Hi

----- Original Message -----
> On Tue, 2015-09-22 at 11:39 -0400, Marc-André Lureau wrote:
> > 
> > ----- Original Message -----
> > > On Tue, 2015-09-22 at 11:30 -0400, Marc-André Lureau wrote:
> > > > 
> > > > ----- Original Message -----
> > > > > Does anybody object to this series?
> > > > 
> > > > Yes, you broke the build with 1/2 and then you fix it in 2/2? and you
> > > > didn't explain what the point of it.
> > > 
> > > The point of it? channel-main.c should include channel-main.h. The fact
> > > that it was indirectly included was only an accident. I thought that
> > > would be self-explanatory. As for combining the two, that's a good
> > > point. Are you ok with it if I squash these?
> > 
> > Hmm, this could potentially break build of other users, since
> > spice-client.h is no longer included by channel-main.h.
> > 
> > Instead, I would suggest to add internal header guards, so only
> > spice-client.h can be included, and you get a compiler warning if not
> > (see how it's done with glib for ex)
> 
> Glib generates a compiler error, not a warning. Are you advocating a
> warning or an error? And are you arguing against removing this circular
> include even with the warning/error?

Since you want to break the current headers implicit inclusion, I'd go with an error.