[Spice-devel] [PATCH] tests: Fix -Werror=format-zero-length build failure

[Jonathon Jongsma]

On Tue, 2015-09-29 at 16:31 +0200, Christophe Fergeau wrote:
> replay.c: In function 'replay_channel_event':
> replay.c:226:16: error: zero-length gnu_printf format string
> [-Werror=format-zero-length]
>      g_printerr("");
> ---
>  server/tests/replay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index efa97e9..c1a53b1 100644
> --- a/server/tests/replay.c
> +++ b/server/tests/replay.c
> @@ -223,7 +223,7 @@ static QXLInterface display_sif = {
>  
>  static void replay_channel_event(int event, SpiceChannelEventInfo *info)
>  {
> -    g_printerr("");
> +    g_printerr("channel event");

hmm, this code is a bit strange. Do you know why we're using
g_printerr() here instead of g_print() or similar? And besides that,
g_printerr() does not append a newline, so this statement actually had
no effect on the output. So I would suggest either removing this print
statement entirely or using something slightly more useful like:

g_print("channel event %i\n", event);


>  
>      if (info->type == SPICE_CHANNEL_DISPLAY &&
>          event == SPICE_CHANNEL_EVENT_INITIALIZED) {