[Spice-devel] [PATCH 5/6] worker: remove redundant check

[Jonathon Jongsma]

On Tue, 2015-09-29 at 11:56 +0100, Frediano Ziglio wrote:
> From: Marc-André Lureau <marcandre.lureau at gmail.com>
> 
> The check is done in draw()


I'm not sure whether this patch can be pulled forward easily. At a
minimum, the commit log references a function that doesn't exist in the
current branch ("draw()"). I spent a little bit of time trying to figure
out whether this patch was still valid, but decided that there was very
little advantage to bringing this patch forward to master, so I decided
not to spend more time on it. I'd recommend just leaving this for now.


> ---
>  server/red_worker.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 38a41a2..3ad6fc0 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -5064,10 +5064,6 @@ static int red_process_commands(RedWorker *worker, uint32_t max_pipe_size, int *
>                                     &update, ext_cmd.cmd.data)) {
>                  break;
>              }
> -            if (!validate_surface(worker, update.surface_id)) {
> -                rendering_incorrect("QXL_CMD_UPDATE");
> -                break;
> -            }
>              red_update_area(worker, &update.area, update.surface_id);
>              worker->qxl->st->qif->notify_update(worker->qxl, update.update_id);
>              release_info_ext.group_id = ext_cmd.group_id;