[Spice-devel] [spice-gtk 4/4] coverity: identical code for different branches

[Victor Toso]

Hey,

>From coverity there are only 2 spice-gtk patches, right?
Both look good to me
Acked-by: Victor Toso <victortoso at redhat.com>

On Mon, Apr 04, 2016 at 10:02:09AM +0200, Fabiano Fidêncio wrote:
> ---
>  src/spice-client-glib-usb-acl-helper.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/spice-client-glib-usb-acl-helper.c b/src/spice-client-glib-usb-acl-helper.c
> index c2baeda..03a0317 100644
> --- a/src/spice-client-glib-usb-acl-helper.c
> +++ b/src/spice-client-glib-usb-acl-helper.c
> @@ -139,8 +139,7 @@ update:
>      /* update record */
>      acl_calc_mask(&acl);
>      ret = acl_set_file(filename, ACL_TYPE_ACCESS, acl);
> -    if (ret != 0)
> -        goto out;
> +
>  out:
>      acl_free(acl);
>      return ret;
> -- 
> 2.7.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel