[Spice-devel] [spice-common 4/8] coverity: avoid dereference after null check

[Victor Toso]

Hi,

On Mon, Apr 04, 2016 at 10:03:35AM +0200, Fabiano Fidêncio wrote:
> All decompress functions used after this check take into account that
> encoder->palette is not NULL. So, if we already detected that the
> palette is NULL, let's just return early.

Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  common/lz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/lz.c b/common/lz.c
> index d1c4033..2589223 100644
> --- a/common/lz.c
> +++ b/common/lz.c
> @@ -647,6 +647,7 @@ void lz_decode(LzContext *lz, LzImageType to_type, uint8_t *buf)
>              if (!encoder->palette) {
>                  encoder->usr->error(encoder->usr,
>                                      "a palette is missing (for bpp to rgb decoding)\n");
> +                return;
>              }
>              switch (encoder->type) {
>              case LZ_IMAGE_TYPE_PLT1_BE:
> -- 
> 2.7.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel