[Spice-devel] [spice-gtk 1/4] coverity: fix unitialized use of mem.data

Christophe Fergeau cfergeau at redhat.com
Mon Apr 4 09:08:39 UTC 2016


Where is the mem.data use you mention? In the memcpy?

Christophe

On Mon, Apr 04, 2016 at 09:59:50AM +0200, Fabiano FidĂȘncio wrote:
> ---
>  src/channel-main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/channel-main.c b/src/channel-main.c
> index 4a1f58a..93537d2 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -1021,9 +1021,9 @@ static void agent_msg_queue_many(SpiceMainChannel *channel, int type, const void
>      }
>      va_end(args);
>  
> +    memset(&msg, 0, sizeof(VDAgentMessage));
>      msg.protocol = VD_AGENT_PROTOCOL;
>      msg.type = type;
> -    msg.opaque = 0;
>      msg.size = size;
>  
>      paysize = MIN(VD_AGENT_MAX_DATA_SIZE, size + sizeof(VDAgentMessage));
> -- 
> 2.7.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160404/18acc0d1/attachment.sig>


More information about the Spice-devel mailing list