[Spice-devel] [spice-gtk 2/3] Send key release event for some keys in JP keyboard.

Takao Fujiwara tfujiwar at redhat.com
Tue Apr 5 11:20:39 UTC 2016


On 03/31/16 22:19, Frediano Ziglio-san wrote:
>> +        switch (key->hardware_keycode) {
>> +        case VK_KANJI:                  /* Alt + Zenkaku_Hankaku */
>> +        case VK_OEM_ATTN:               /* Eisu_toggle */
>> +        case VK_OEM_COPY:               /* Hiragana_Katakana */
>> +        case VK_OEM_BACKTAB:            /* Alt + Hiragana_Katakana */
>> +            no_key_release = TRUE;
>> +            break;
>
> Unfortunately this is not exactly true. Some keys are just inverted,
> some others depends on IME mode.
> Sending always the release cause in some case to send 2 times the press/release
> combination. This could cause some issues depending on guest settings.
> Usually however this code produce multiple releases which are harmless.

Right. I added more comment lines to explain the problems.



More information about the Spice-devel mailing list