[Spice-devel] [PATCH 06/13] spicevmc: Move SpiceVmcState::pipe_item to RedCharDeviceSpiceVmc

[Christophe Fergeau]

Hey,

On Tue, Mar 29, 2016 at 04:21:50PM -0500, Jonathon Jongsma wrote:
> On Wed, 2016-03-23 at 12:48 +0000, Frediano Ziglio wrote:
> > From: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > This pipe item belongs to the char device, not to the spicevmc channel.
> 
> I'm not so sure about this. In general PipeItem seems to be pretty closely tied
> to spice communication (i.e. spice channels and channel clients). I'm curious
> why you think it belongs in the char device.

Looked again at this patch, and to be honest I don't know :) Looking at
it again, I agree we can drop this patch.


> On a somewhat-related note: can we add a FIXME to change the type name from
> SpiceVmcState to SpiceVmcChannel? I find the current name rather confusing. I
> was going to write a quick patch to do that, but I really don't want to
> complicate the future patches in the series.

This would indeed makes things much clearer.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160406/0193805a/attachment.sig>