[Spice-devel] [PATCH 04/14] reds: Put PipeItem first in VDIReadBuf

Jonathon Jongsma jjongsma at redhat.com
Fri Apr 8 20:33:03 UTC 2016


I don't know if something got messed up during a rebase (that doesn't appear to
be the case), but I don't really understand this commit or how the patch relates
to the commit log...

On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>
> 
> This is a bit artificial as this is not a real 'PipeItem', but it will
> allow us to make it use the common base class for refcounted pipe items.
> ---
>  server/reds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 792e45f..1c37627 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -167,9 +167,9 @@ struct ChannelSecurityOptions {
>  };
>  
>  typedef struct VDIReadBuf {
> -    RedCharDeviceVDIPort *dev;
>      RingItem link;
>      uint32_t refs;
> +    RedCharDeviceVDIPort *dev;
>  
>      int len;
>      uint8_t data[SPICE_AGENT_MAX_DATA_SIZE];


Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>


More information about the Spice-devel mailing list