[Spice-devel] [spice-gtk v4 0/3] Windows Japanese layout workarounds

Takao Fujiwara tfujiwar at redhat.com
Mon Apr 18 09:40:26 UTC 2016


On 04/18/16 18:03, Frediano Ziglio-san wrote:
>>
>> Hi,
>>
>> the patches looks good to me. They should not cause regressions in
>> non-japanese/korean env. Missing release key events can be eventually
>> fixed somewhere else (Windows ? gtk+ ?).
>>
>> Thanks,
>> Pavel
>>
>
> Merged!
>
> Lot of TODOs...
> For the scancode I think the best place is GDK (with a patch less hacky
> than the one I proposed)
> For the missing release I think the best place would be Windows but I
> doubt to have the fix there and possibly would cause trouble in GDK too.
> It seems Windows try to emulate an old Japanese keyboard changing a lot
> (at the kernel driver level) the keys (the "seems" is bound to the
> emulation, for sure keys are changed and from user space you can't get
> the keys, you can only do workarounds!).
>
> Frediano

Thanks for the code reviews and commits.
Probably I agree with the evaluation.

MapVirtualKey(vk, MAPVK_VK_TO_VSC) misses some scancodes but MapVirtualKey(vsc, MAPVK_VSC_TO_VK) returns expected values.

Fujiwara

>
>> On Fri, 2016-04-15 at 12:11 +0100, Frediano Ziglio wrote:
>>> This version contains style change:
>>> - remove goto/label;
>>> - remove useless default switch.
>>>
>>> Takao Fujiwara (3):
>>>    Send Zenkaku_Hankaku key in JP keyboard
>>>    Send key release event for some keys in JP keyboard
>>>    Send Hangul key in KR keyboard
>>>
>>>   src/spice-widget.c | 99
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++--
>>>   1 file changed, 97 insertions(+), 2 deletions(-)
>>>
>>
>



More information about the Spice-devel mailing list