[Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

[Francois Gouget]

On Tue, 19 Apr 2016, Pavel Grunt wrote:

> Hi Francois,
> 
> what error did you get? The function is used in canvas_get_lz()
> and canvas_get_lz4().

  CC       sw-canvas.lo
In file included from ../spice-common/common/sw_canvas.c:29:0,
                 from sw-canvas.c:22:
../spice-common/common/canvas_base.c:518:13: error: 
'canvas_fix_alignment' defined but not used [-Werror=unused-function]
 static void canvas_fix_alignment(uint8_t *bits,
             ^
cc1: all warnings being treated as errors


This is with the 2eaf7c9572746bcc0edc52871974d4085618f3e5 spice-common 
checkout.

Looking into this I noticed that:
 * SW_CANVAS_CACHE is not defined anywhere in the server (all I can find 
   are #ifdef checks, spice-gtk does define it however).
 * And apparently I don't have the liblz4 development files. Installing 
   those would certainly fix this issue but spice-common should still 
   compile in this configuration.

-- 
Francois Gouget <fgouget at codeweavers.com>