[Spice-devel] [PATCH 15/16] Remove dead code in reds_fill_channels()

Jonathon Jongsma jjongsma at redhat.com
Tue Apr 19 21:38:56 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Tue, 2016-04-19 at 11:00 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>
> 
> channels_info->num_of_channels is assigned, its value is not used, and
> then it's assigned a different value. The first assignment can be
> removed.
> ---
>  server/reds.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 556d0cb..337d90b 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1004,7 +1004,6 @@ static void reds_fill_channels(RedsState *reds,
> SpiceMsgChannels *channels_info)
>      RingItem *now;
>      int used_channels = 0;
>  
> -    channels_info->num_of_channels = reds->num_of_channels;
>      RING_FOREACH(now, &reds->channels) {
>          RedChannel *channel = SPICE_CONTAINEROF(now, RedChannel, link);
>          if (reds->num_clients > 1 &&


More information about the Spice-devel mailing list