[Spice-devel] [spice-common 8/8] Use g_getenv() instead of getenv()

Christophe Fergeau cfergeau at redhat.com
Mon Apr 25 08:53:55 UTC 2016


On Mon, Apr 25, 2016 at 09:08:23AM +0200, Fabiano FidĂȘncio wrote:
> On Mon, Apr 4, 2016 at 10:21 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Mon, Apr 04, 2016 at 10:03:39AM +0200, Fabiano FidĂȘncio wrote:
> >> ---
> >>  common/log.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/common/log.c b/common/log.c
> >> index 8d47cb6..91d3181 100644
> >> --- a/common/log.c
> >> +++ b/common/log.c
> >> @@ -59,7 +59,7 @@ static GLogLevelFlags spice_log_level_to_glib(SpiceLogLevel level)
> >>  static void spice_log_set_debug_level(void)
> >>  {
> >>      if (glib_debug_level == 0) {
> >> -        char *debug_str = getenv("SPICE_DEBUG_LEVEL");
> >> +        char *debug_str = (char *)g_getenv("SPICE_DEBUG_LEVEL");
> >
> > Looks like it could be
> > const char *debug_str = g_getenv(...) ?
> 
> ACK with this change?

Sure!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160425/31f5f80a/attachment.sig>


More information about the Spice-devel mailing list