[Spice-devel] [spice-gtk v2 0/9] file-transfer leaks and fixes

Victor Toso victortoso at redhat.com
Tue Aug 2 09:48:41 UTC 2016


Hi,

email-v1: https://lists.freedesktop.org/archives/spice-devel/2016-July/030951.html
branch: https://cgit.freedesktop.org/~victortoso/spice-gtk/log/?h=file-transfer

v1 -> v2:
* Improved commit log from:
- "channel-main: avoid race around file-transfer flush"
- "file-transfer: Fix SpiceFileTransferTask::error leak"

* Using g_hash_table_full with g_object_unref() for GHashTable given by
  spice_file_transfer_task_create_tasks()
- removed patch: "test-file-transfer: Don't leak SpiceFileTransferTask"

* "file-transfer: fix leak on _task_get_filename"
- Instead of fixing the leak in spice-gtk, let's change the documentation
  instead to transfer full and fix spicy and remote-viewer.
- Changed to "spicy: Fix spice_file_transfer_task_get_filename leak" from teuf's
  branch

Christophe Fergeau (6):
  test-file-transfer: Don't leak GFileInfo
  test-file-transfer: Don't leak GError
  file-transfer: Fix GTask leaks
  file-transfer: Fix SpiceFileTransferTask::file_stream leak
  file-transfer: avoid potential leaks
  spicy: Fix spice_file_transfer_task_get_filename leak

Victor Toso (3):
  file-transfer: Fix SpiceFileTransferTask::error leak
  file-transfer: increase reference for channel-main
  channel-main: avoid race around file-transfer flush

 src/channel-main.c                  | 23 ++++++++++--------
 src/spice-file-transfer-task-priv.h |  1 +
 src/spice-file-transfer-task.c      | 48 ++++++++++++++++++++++++++++++-------
 src/spicy.c                         |  5 +++-
 tests/file-transfer.c               |  7 ++++++
 5 files changed, 64 insertions(+), 20 deletions(-)

-- 
2.7.4



More information about the Spice-devel mailing list