[Spice-devel] [PATCH v2] gstreamer: Allows to add output format to options

[Pavel Grunt]

On Wed, 2016-08-03 at 12:47 +0100, Frediano Ziglio wrote:
> This allow option string to contain separator so you could set as
> "field=value ! format".
> This is useful as some encoders use the output format to specify
> compression types (for instance with some H264 encoders you can
> specify the profile to use).
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/gstreamer-encoder.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Changes since v1:
> - split the long line, was really long.
> 
> diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> index e364ea3..e6790af 100644
> --- a/server/gstreamer-encoder.c
> +++ b/server/gstreamer-encoder.c
> @@ -939,7 +939,9 @@ static gboolean create_pipeline(SpiceGstEncoder *encoder)
>      }
>  
>      GError *err = NULL;
> -    gchar *desc = g_strdup_printf("appsrc is-live=true format=time do-
> timestamp=true name=src ! %s ! %s %s name=encoder ! appsink name=sink",
> converter, gstenc_name, gstenc_opts);
> +    gchar *desc = g_strdup_printf("appsrc is-live=true format=time do-
> timestamp=true name=src !"
> +                                  " %s ! %s name=encoder %s ! appsink
> name=sink",
> +                                  converter, gstenc_name, gstenc_opts);
>      spice_debug("GStreamer pipeline: %s", desc);
>      encoder->pipeline = gst_parse_launch_full(desc, NULL,
> GST_PARSE_FLAG_FATAL_ERRORS, &err);
>      g_free(gstenc_opts);