[Spice-devel] [usbredir v1] usbredirhost: avoid access to null pointer

Pavel Grunt pgrunt at redhat.com
Thu Aug 4 06:30:47 UTC 2016


On Wed, 2016-08-03 at 18:59 +0200, Victor Toso wrote:
> Another coverity complain.
Does it say where it is potentially called with null host ?
> ---
>  usbredirhost/usbredirhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/usbredirhost.c
> index 22c5e39..7d57d40 100644
> --- a/usbredirhost/usbredirhost.c
> +++ b/usbredirhost/usbredirhost.c
> @@ -160,7 +160,7 @@ va_log(struct usbredirhost *host, int level, const char
> *fmt, ...)
>      va_list ap;
>      int n;
>  
> -    if (level > host->verbose) {
> +    if (host == NULL || level > host->verbose) {
>          return;
>      }
>  


More information about the Spice-devel mailing list