[Spice-devel] [PATCH win-vdagent v2 1/2] Introducing Windows CCD API
Sameeh Jubran
sameeh at daynix.com
Thu Aug 4 10:42:56 UTC 2016
Hi Frediano,
Thanks for the review.
I'll fix the issues and resend the patch.
Regarding “underscore uppercase” issue, I have already checked the style in
other files
and that's how they did it. For example in desktop_layout.h the identifier
is "_H_DESKTOP_LAYOUT".
On Wed, Aug 3, 2016 at 7:42 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
> >
> > The Connecting and Configuring Displays (CCD) Win32 APIs
> > provide more control over the desktop display setup. The CCD APIs
> > move away from using Windows Graphics Device Interface (GDI)
> > concepts like view name and toward Windows Display Driver Model
> > (WDDM) concepts like adapter, source, and target identifiers.
> > More info on the CCD API can be found here:
> >
> https://msdn.microsoft.com/en-us/library/windows/hardware/ff539590(v=vs.85).aspx
> >
> > This patch introduces partial functionality from the CCD API
> > needed by vdagent. It is needed by vdagent in order to support
> > multiple monitors and arbitrary resolution on Windows 10.
> >
> > Based on a patch by Sandy Stutsman <sstutsma at redhat.com>
> >
> > Signed-off-by: Dmitry Fleytman <dfleytma at redhat.com>
> > Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> > ---
> > Makefile.am | 2 +
> > vdagent/display_configuration.cpp | 509
> > ++++++++++++++++++++++++++++++++++++++
> > vdagent/display_configuration.h | 94 +++++++
> > 3 files changed, 605 insertions(+)
> > create mode 100755 vdagent/display_configuration.cpp
> > create mode 100755 vdagent/display_configuration.h
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index c3fc6bf..84507e8 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -31,6 +31,8 @@ vdagent_SOURCES = \
> > common/vdcommon.h \
> > common/vdlog.cpp \
> > common/vdlog.h \
> > + vdagent/display_configuration.cpp \
> > + vdagent/display_configuration.h \
> > vdagent/desktop_layout.cpp \
> > vdagent/desktop_layout.h \
> > vdagent/display_setting.cpp \
> > diff --git a/vdagent/display_configuration.cpp
> > b/vdagent/display_configuration.cpp
> > new file mode 100755
> > index 0000000..12b9c22
> > --- /dev/null
> > +++ b/vdagent/display_configuration.cpp
> > @@ -0,0 +1,509 @@
> > +/*
> > +Copyright (C) 2015 Red Hat, Inc.
> > +
> > +This program is free software; you can redistribute it and/or
> > +modify it under the terms of the GNU General Public License as
> > +published by the Free Software Foundation; either version 2 of
> > +the License, or (at your option) any later version.
> > +
> > +This program is distributed in the hope that it will be useful,
> > +but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > +GNU General Public License for more details.
> > +
> > +You should have received a copy of the GNU General Public License
> > +along with this program. If not, see <http://www.gnu.org/licenses/>.
> > +*/
> > +
> > +#include "display_configuration.h"
> > +#include <winternl.h>
> > +
> > +/* The following definitions and structures are taken
> > +from the wine project repository and can be found
> > +under: "wine/include/wingdi.h" */
> > +
> > +#define QDC_ALL_PATHS 0x00000001
> > +
> > +#define SDC_USE_SUPPLIED_DISPLAY_CONFIG 0x00000020
> > +#define SDC_APPLY 0x00000080
> > +#define SDC_FORCE_MODE_ENUMERATION 0x00001000
> > +
> > +#define DISPLAYCONFIG_PATH_ACTIVE 0x00000001
> > +#define DISPLAYCONFIG_PATH_MODE_IDX_INVALID 0xffffffff
> > +
> > +enum DISPLAYCONFIG_DEVICE_INFO_TYPE {
> > + DISPLAYCONFIG_DEVICE_INFO_GET_SOURCE_NAME = 1
> > +};
> > +
> > +enum DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY {};
> > +
> > +enum DISPLAYCONFIG_ROTATION {};
> > +
> > +enum DISPLAYCONFIG_SCANLINE_ORDERING {};
> > +
> > +enum DISPLAYCONFIG_SCALING {};
> > +
> > +enum DISPLAYCONFIG_PIXELFORMAT {};
> > +
> > +enum DISPLAYCONFIG_MODE_INFO_TYPE {};
> > +
> > +struct DISPLAYCONFIG_DEVICE_INFO_HEADER {
> > + DISPLAYCONFIG_DEVICE_INFO_TYPE type;
> > + UINT32 size;
> > + LUID adapterId;
> > + UINT32 id;
> > +};
> > +
> > +struct DISPLAYCONFIG_SOURCE_DEVICE_NAME {
> > + DISPLAYCONFIG_DEVICE_INFO_HEADER header;
> > + WCHAR
> > viewGdiDeviceName[CCHDEVICENAME];
> > +};
> > +
> > +struct DISPLAYCONFIG_DESKTOP_IMAGE_INFO {
> > + POINTL PathSourceSize;
> > + RECTL DesktopImageRegion;
> > + RECTL DesktopImageClip;
> > +};
> > +
> > +struct DISPLAYCONFIG_RATIONAL {
> > + UINT32 Numerator;
> > + UINT32 Denominator;
> > +};
> > +
> > +struct DISPLAYCONFIG_2DREGION {
> > + UINT32 cx;
> > + UINT32 cy;
> > +};
> > +
> > +struct DISPLAYCONFIG_VIDEO_SIGNAL_INFO {
> > + UINT64 pixelRate;
> > + DISPLAYCONFIG_RATIONAL hSyncFreq;
> > + DISPLAYCONFIG_RATIONAL vSyncFreq;
> > + DISPLAYCONFIG_2DREGION activeSize;
> > + DISPLAYCONFIG_2DREGION totalSize;
> > + union {
> > + struct {
> > + UINT32 videoStandard :16;
> > + UINT32 vSyncFreqDivider :6;
> > + UINT32 reserved :10;
> > + } AdditionalSignalInfo;
> > + UINT32 videoStandard;
> > + } DUMMYUNIONNAME;
> > + DISPLAYCONFIG_SCANLINE_ORDERING scanLineOrdering;
> > +};
> > +
> > +struct DISPLAYCONFIG_TARGET_MODE {
> > + DISPLAYCONFIG_VIDEO_SIGNAL_INFO targetVideoSignalInfo;
> > +};
> > +
> > +struct DISPLAYCONFIG_SOURCE_MODE {
> > + UINT32 width;
> > + UINT32 height;
> > + DISPLAYCONFIG_PIXELFORMAT pixelFormat;
> > + POINTL position;
> > +};
> > +
> > +struct DISPLAYCONFIG_MODE_INFO {
> > + DISPLAYCONFIG_MODE_INFO_TYPE infoType;
> > + UINT32 id;
> > + LUID adapterId;
> > + union {
> > + DISPLAYCONFIG_TARGET_MODE targetMode;
> > + DISPLAYCONFIG_SOURCE_MODE sourceMode;
> > + DISPLAYCONFIG_DESKTOP_IMAGE_INFO desktopImageInfo;
> > + } DUMMYUNIONNAME;
> > +};
> > +
> > +struct DISPLAYCONFIG_PATH_SOURCE_INFO {
> > + LUID adapterId;
> > + UINT32 id;
> > + union {
> > + UINT32 modeInfoIdx;
> > + struct {
> > + UINT32 cloneGroupId :16;
> > + UINT32 sourceModeInfoIdx :16;
> > + } DUMMYSTRUCTNAME;
> > + } DUMMYUNIONNAME;
> > + UINT32 statusFlags;
> > +};
> > +
> > +struct DISPLAYCONFIG_PATH_TARGET_INFO {
> > + LUID adapterId;
> > + UINT32 id;
> > + union {
> > + UINT32 modeInfoIdx;
> > + struct {
> > + UINT32 desktopModeInfoIdx :16;
> > + UINT32 targetModeInfoIdx :16;
> > + } DUMMYSTRUCTNAME;
> > + } DUMMYUNIONNAME;
> > + DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY outputTechnology;
> > + DISPLAYCONFIG_ROTATION rotation;
> > + DISPLAYCONFIG_SCALING scaling;
> > + DISPLAYCONFIG_RATIONAL refreshRate;
> > + DISPLAYCONFIG_SCANLINE_ORDERING scanLineOrdering;
> > + BOOL targetAvailable;
> > + UINT32 statusFlags;
> > +};
> > +
> > +struct DISPLAYCONFIG_PATH_INFO {
> > + DISPLAYCONFIG_PATH_SOURCE_INFO sourceInfo;
> > + DISPLAYCONFIG_PATH_TARGET_INFO targetInfo;
> > + UINT32 flags;
> > +};
> > +
> > +CCD::CCD()
> > + :_NumPathElements(0)
> > + ,_NumModeElements(0)
> > + ,_pPathInfo(NULL)
> > + ,_pModeInfo(NULL)
> > + ,_pfnGetDeviceInfo(NULL)
> > + ,_pfnGetDisplayConfigBufferSizes(NULL)
> > + ,_pfnQueryDisplayConfig(NULL)
> > + ,_pfnSetDisplayConfig(NULL)
> > + ,_error(0)
> > + ,_primary_detached(false)
> > + ,_path_state(PATH_UPDATED)
> > +{
> > + if (load_api()) {
> > + get_config_buffers();
> > + }
> > +}
> > +
> > +CCD::~CCD()
> > +{
> > + free_config_buffers();
> > +}
> > +
> > +bool CCD::query_display_config()
> > +{
> > + LONG query_error(ERROR_SUCCESS);
> > +
> > + //Until we get it or error != ERROR_INSUFFICIENT_BUFFER
> > + do {
> > + query_error = _pfnQueryDisplayConfig(QDC_ALL_PATHS,
> > &_NumPathElements, _pPathInfo,
> > + &_NumModeElements, _pModeInfo, NULL);
> > +
> > + // if ERROR_INSUFFICIENT_BUFFER need to retry QueryDisplayConfig
> > + // to get a new set of config buffers
> > + //(see
> >
> https://msdn.microsoft.com/en-us/library/windows/hardware/ff569215(v=vs.85).aspx
> > )
> > + if (query_error) {
> > + if (query_error == ERROR_INSUFFICIENT_BUFFER) {
> > + free_config_buffers();
> > + if (!get_config_buffers())
> > + return false;
> > + } else {
> > + _error = query_error;
> > + vd_printf("%s failed QueryDisplayConfig with 0x%lx",
> > __FUNCTION__, _error);
> > + return false;
> > + }
> > + }
> > + } while(query_error);
> > + _path_state = PATH_CURRENT;
> > + return true;
> > +}
> > +
> > +DISPLAYCONFIG_MODE_INFO* CCD::get_active_mode(LPCTSTR device_name, bool
> > return_on_error)
> > +{
> > + DISPLAYCONFIG_PATH_INFO* active_path;
> > +
> > + active_path = get_device_path(device_name, true);
> > +
> > + if (!active_path ) {
> > + vd_printf("%s:%S failed", __FUNCTION__, device_name);
> > + return NULL;
> > + }
> > + return &_pModeInfo[active_path->sourceInfo.modeInfoIdx];
> > +}
> > +
> > +bool CCD::set_display_config() {
> > +
> > + debug_print_config("Before SetDisplayConfig");
> > +
> > + if (_path_state == PATH_CURRENT) {
> > + vd_printf("%s: path states says nothing changed", __FUNCTION__);
> > + return true;
> > + }
> > +
> > + if (!(_error = _pfnSetDisplayConfig(_NumPathElements, _pPathInfo,
> > + _NumModeElements, _pModeInfo,
> > + SDC_APPLY | SDC_USE_SUPPLIED_DISPLAY_CONFIG |
> > SDC_FORCE_MODE_ENUMERATION))) {
> > + return true;
> > + }
> > +
> > + vd_printf("%s failed SetDisplayConfig with 0x%lx", __FUNCTION__,
> > _error);
> > + debug_print_config("After failed SetDisplayConfig");
> > + return false;
> > +}
> > +
> > +DISPLAYCONFIG_PATH_INFO* CCD::get_device_path(LPCTSTR device_name, bool
> > bActive)
> > +{
> > + //Search for device's active path
> > + for (UINT32 i = 0; i < _NumPathElements; i++) {
> > + DISPLAYCONFIG_PATH_INFO* path_info = &_pPathInfo[i];
> > +
> > + //if bActive, return only paths that are currently active
> > + if (bActive && !is_active_path(path_info))
> > + continue;
> > + if (!is_device_path(device_name, path_info))
> > + continue;
> > + return path_info;
> > + }
> > + _error = ERROR_GEN_FAILURE;
> > + return NULL;
> > +}
> > +
> > +void CCD::debug_print_config(const char* prefix)
> > +{
> > + TCHAR dev_name[CCHDEVICENAME];
> > + for (UINT32 i = 0; i < _NumPathElements; i++) {
> > + DISPLAYCONFIG_PATH_INFO* path_info = &_pPathInfo[i];
> > + if (!(path_info->flags & DISPLAYCONFIG_PATH_ACTIVE))
> > + continue;
> > + get_device_name_config(path_info, dev_name);
> > +
> > + if (path_info->sourceInfo.modeInfoIdx ==
> > DISPLAYCONFIG_PATH_MODE_IDX_INVALID) {
> > + vd_printf("%s: %S [%s] This path is active but has invalid
> mode
> > set.", __FUNCTION__,
> > + dev_name, prefix);
> > + continue;
> > + }
> > + DISPLAYCONFIG_MODE_INFO* mode =
> > &_pModeInfo[path_info->sourceInfo.modeInfoIdx];
> > + vd_printf("%s: %S [%s] (%ld,%ld) (%ux%u).", __FUNCTION__,
> dev_name,
> > prefix,
> > + mode->sourceMode.position.x, mode->sourceMode.position.y,
> > + mode->sourceMode.width, mode->sourceMode.height);
> > + }
> > +}
> > +
> > +bool CCD::load_api()
> > +{
> > + HMODULE hModule = LoadLibrary(L"user32.dll");
> > + if(!hModule) {
> > + return false;
> > + }
> > +
> > + bool bFound_all(false);
> > + do {
> > + if (!(_pfnGetDeviceInfo = (PDISPLAYCONFIG_GETDEVICEINFO)
> > + GetProcAddress(hModule, "DisplayConfigGetDeviceInfo"))) {
> > + break;
> > + }
> > +
> > + if (!(_pfnGetDisplayConfigBufferSizes =
> > (PGETDISPLAYCONFIG_BUFFERSIZES)
> > + GetProcAddress(hModule, "GetDisplayConfigBufferSizes"))) {
> > + break;
> > + }
> > +
> > + if (!(_pfnQueryDisplayConfig = (PQUERYDISPLAYCONFIG)
> > + GetProcAddress(hModule, "QueryDisplayConfig"))) {
> > + break;
> > + }
> > +
> > + if (!(_pfnSetDisplayConfig = (PSETDISPLAYCONFIG)
> > + GetProcAddress(hModule, "SetDisplayConfig"))) {
> > + break;
> > + }
> > + bFound_all = true;
> > + }
> > + while(0);
> > +
> > + FreeLibrary(hModule);
>
> You'll get a possible crash if you are really freeing
> the library. I think however would be better to just use
> GetModuleHandle instead of LoadLibrary.
>
> The reason of the crash is that if the module is not loaded
> you load with LoadLibrary, get the function pointer then
> with FreeLibrary the library is unloaded and the pointers
> are now invalid resulting in a crash if used. However being
> user32 surely be used by this application using GetModuleHandle
> avoid this issue.
>
> > + return bFound_all;
> > +}
> > +
> > +bool CCD::get_config_buffers()
> > +{
> > + //Get Config Buffer Sizes
> > + free_config_buffers();
> > + _error = _pfnGetDisplayConfigBufferSizes(QDC_ALL_PATHS,
> > &_NumPathElements,
> > + &_NumModeElements);
> > + if (_error) {
> > + vd_printf("%s: GetDisplayConfigBufferSizes failed with 0x%lx",
> > __FUNCTION__, _error);
> > + return false;
> > + }
> > +
> > + //Allocate arrays
> > + _pPathInfo = ((DISPLAYCONFIG_PATH_INFO*)
> > malloc(sizeof(DISPLAYCONFIG_PATH_INFO) * _NumPathElements));
> > + _pModeInfo = ((DISPLAYCONFIG_MODE_INFO*)
> > malloc(sizeof(DISPLAYCONFIG_MODE_INFO) * _NumModeElements));
> > +
>
> I'm a bit puzzled about the memory style. Sometimes it's new/delete
> sometimes is something more low level like malloc/free.
> Actually I thought the idea was reducing memory and avoid using
> exceptions or STL however I also found a std::vector usage (and other
> containers too).
>
> > + if (!_pPathInfo || !_pModeInfo) {
> > + vd_printf("%s OOM ", __FUNCTION__);
> > + return false;
> > + }
> > +
> > + ///clear the above arrays
> > + ZeroMemory(_pPathInfo, sizeof(DISPLAYCONFIG_PATH_INFO) *
> > _NumPathElements);
> > + ZeroMemory(_pModeInfo, sizeof(DISPLAYCONFIG_MODE_INFO) *
> > _NumModeElements);
> > + return true;
> > +}
> > +
> > +void CCD::free_config_buffers()
> > +{
> > + if (_pModeInfo) {
> > + free(_pModeInfo);
> > + _pModeInfo = NULL;
> > + }
> > + if (_pPathInfo) {
> > + free(_pPathInfo);
> > + _pPathInfo = NULL;
> > + }
> > + _NumModeElements = _NumPathElements = 0;
> > +}
> > +
> > +bool CCD::get_device_name_config(DISPLAYCONFIG_PATH_INFO* path, LPCTSTR
> > dev_name)
> > +{
> > + DISPLAYCONFIG_SOURCE_DEVICE_NAME source_name;
> > + source_name.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_SOURCE_NAME;
> > + source_name.header.size = sizeof(DISPLAYCONFIG_SOURCE_DEVICE_NAME);
> > + source_name.header.adapterId = path->sourceInfo.adapterId;
> > + source_name.header.id = path->sourceInfo.id;
> > +
> > + _error = _pfnGetDeviceInfo(&source_name.header);
> > + if (_error) {
> > + vd_printf("%s DisplayConfigGetDeviceInfo failed with %lu",
> > __FUNCTION__, _error);
> > + return false;
> > + }
> > + memcpy((void *)dev_name, source_name.viewGdiDeviceName,
> CCHDEVICENAME*
> > sizeof(TCHAR));
> > + return true;
> > +}
> > +
> > +bool CCD::is_device_path(LPCTSTR device_name, DISPLAYCONFIG_PATH_INFO*
> path)
> > +{
> > + //Does this path belong to device_name?
> > + TCHAR dev_name[CCHDEVICENAME];
> > + if (!get_device_name_config(path, dev_name)) {
> > + return false;
> > + }
> > + if (_tcscmp(dev_name, device_name)) {
> > + return false;
> > + }
> > + return true;
> > +}
> > +
> > +// If we have detached the primary monitor, then we need to reset the
> > positions of the remaining
> > +// monitors to insure that at least one is positioned at (0,0)
> > +bool CCD::verify_primary_position()
> > +{
> > + LONG leftmost_x(0);
> > + if (!_primary_detached) {
> > + return true;
> > + }
> > + _primary_detached = false;
> > +
> > + for (UINT32 i = 0; i < _NumPathElements; i++) {
> > + DISPLAYCONFIG_PATH_INFO* path_info = &_pPathInfo[i];
> > + if (!(path_info->flags & DISPLAYCONFIG_PATH_ACTIVE))
> > + continue;
> > +
> > + DISPLAYCONFIG_MODE_INFO* mode =
> > &_pModeInfo[path_info->sourceInfo.modeInfoIdx];
> > + if (leftmost_x > mode->sourceMode.position.x) {
> > + leftmost_x = mode->sourceMode.position.x;
> > + }
> > + }
> > +
> > + if (leftmost_x == 0) {
> > + return false;
> > + }
> > +
> > + for (UINT32 i = 0; i < _NumPathElements; i++) {
> > + DISPLAYCONFIG_PATH_INFO* path_info = &_pPathInfo[i];
> > + if ((!(path_info->flags & DISPLAYCONFIG_PATH_ACTIVE)))
> > + continue;
> > + DISPLAYCONFIG_MODE_INFO* mode =
> > &_pModeInfo[path_info->sourceInfo.modeInfoIdx];
> > + vd_printf("%s: setting mode x to %lu", __FUNCTION__,
> > mode->sourceMode.position.x);
> > + mode->sourceMode.position.x -= leftmost_x;
> > + }
> > + _path_state = PATH_UPDATED;
> > + return true;
> > +}
> > +
> > +bool CCD::update_mode_position(LPCTSTR device_name, DEVMODE* dev_mode)
> > +{
> > + DISPLAYCONFIG_MODE_INFO* mode = get_active_mode(device_name, false);
> > + if (!mode)
> > + return false;
> > +
> > + mode->sourceMode.position.x = dev_mode->dmPosition.x;
> > + mode->sourceMode.position.y = dev_mode->dmPosition.y;
> > + vd_printf("%s: %S updated path mode to (%lu, %lu) - (%u x%u)",
> > __FUNCTION__,
> > + device_name,
> > + mode->sourceMode.position.x, mode->sourceMode.position.y,
> > + mode->sourceMode.width, mode->sourceMode.height);
> > + _path_state = PATH_UPDATED;
> > + return true;
> > +
> > +}
> > +
> > +bool CCD::update_mode_size(LPCTSTR device_name, DEVMODE* dev_mode)
> > +{
> > + DISPLAYCONFIG_MODE_INFO* mode = get_active_mode(device_name, false);
> > + if (!mode) {
> > + return false;
> > + }
> > +
> > + mode->sourceMode.width = dev_mode->dmPelsWidth;
> > + mode->sourceMode.height = dev_mode->dmPelsHeight;
> > + vd_printf("%s: %S updated path mode to (%lu, %lu - (%u x %u)",
> > __FUNCTION__,
> > + device_name,
> > + mode->sourceMode.position.x, mode->sourceMode.position.y,
> > + mode->sourceMode.width, mode->sourceMode.height);
> > + _path_state = PATH_UPDATED;
> > + return true;
> > +}
> > +
> > +void CCD::update_detached_primary_state(LPCTSTR device_name,
> > DISPLAYCONFIG_PATH_INFO * path_info)
> > +{
> > + DISPLAYCONFIG_MODE_INFO* mode(get_active_mode(device_name, false));
> > +
> > + //will need to reset monitor positions if primary detached
> > + path_info->flags = path_info->flags & ~DISPLAYCONFIG_PATH_ACTIVE;
> > + if (!mode|| mode->sourceMode.position.x != 0 ||
> > mode->sourceMode.position.y != 0) {
> > + return ;
> > + }
> > + _primary_detached = true;
> > +}
> > +
> > +bool CCD::set_path_state(LPCTSTR device_name, MONITOR_STATE new_state)
> > +{
> > + DISPLAYCONFIG_PATH_INFO* path(get_device_path(device_name, false));
> > + MONITOR_STATE current_path_state(MONITOR_DETACHED);
> > +
> > + if (path && (path->flags & DISPLAYCONFIG_PATH_ACTIVE)) {
> > + current_path_state = MONITOR_ATTACHED;
> > + }
> > +
> > + //If state didn't change, nothing to do
> > + if (current_path_state == new_state ) {
> > + return true;
> > + }
> > +
> > + if (!path) {
> > + return false;
> > + }
> > +
> > + _path_state = PATH_UPDATED;
> > + if (new_state == MONITOR_DETACHED) {
> > + update_detached_primary_state(device_name, path);
> > + } else {
> > + path->flags = path->flags | DISPLAYCONFIG_PATH_ACTIVE;
> > + set_display_config();
> > + }
> > + return true;
> > +}
> > +
> > +bool CCD::is_attached(LPCTSTR device_name)
> > +{
> > + DISPLAYCONFIG_PATH_INFO* path(get_device_path(device_name, false));
> > + if (!path) {
> > + return false;
> > + }
> > + return (path->flags & DISPLAYCONFIG_PATH_ACTIVE);
> > +}
> > +
> > +bool CCD::is_active_path(DISPLAYCONFIG_PATH_INFO * path)
> > +{
> > + if (!path || !(path->flags & DISPLAYCONFIG_PATH_ACTIVE) ||
> > + (path->sourceInfo.modeInfoIdx ==
> > DISPLAYCONFIG_PATH_MODE_IDX_INVALID)) {
> > + return false;
> > + }
> > + return true;
> > +}
> > diff --git a/vdagent/display_configuration.h
> > b/vdagent/display_configuration.h
> > new file mode 100755
> > index 0000000..4a1a7d4
> > --- /dev/null
> > +++ b/vdagent/display_configuration.h
> > @@ -0,0 +1,94 @@
> > +/*
> > +Copyright (C) 2015 Red Hat, Inc.
> > +
> > +This program is free software; you can redistribute it and/or
> > +modify it under the terms of the GNU General Public License as
> > +published by the Free Software Foundation; either version 2 of
> > +the License, or (at your option) any later version.
> > +
> > +This program is distributed in the hope that it will be useful,
> > +but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > +GNU General Public License for more details.
> > +
> > +You should have received a copy of the GNU General Public License
> > +along with this program. If not, see <http://www.gnu.org/licenses/>.
> > +*/
> > +#ifndef _H_DISPLAY_CONFIGURATION
> > +#define _H_DISPLAY_CONFIGURATION
> > +
>
> Underscore uppercase identifiers are deprecated since C99 and C++89,
> and this is C++ so 27 years ago.
>
> > +#include <spice/qxl_windows.h>
> > +#include <spice/qxl_dev.h>
> > +#include "desktop_layout.h"
> > +#include "vdlog.h"
> > +
> > +enum MONITOR_STATE {
> > + MONITOR_DETACHED,
> > + MONITOR_ATTACHED,
> > +};
> > +
> > +enum PATH_STATE {
> > + PATH_UPDATED,
> > + PATH_CURRENT,
> > +};
> > +
> > +enum DISPLAYCONFIG_TOPOLOGY_ID {};
> > +
> > +struct DISPLAYCONFIG_DEVICE_INFO_HEADER;
> > +struct DISPLAYCONFIG_MODE_INFO;
> > +struct DISPLAYCONFIG_PATH_INFO;
> > +
> > +//Makes calls into the CCD API for getting/setting display settings on
> WDDM
> > drivers
> > +//Use is exclusive to wddm display config class
> > +
> > +typedef LONG(APIENTRY*
> > PDISPLAYCONFIG_GETDEVICEINFO)(DISPLAYCONFIG_DEVICE_INFO_HEADER*);
> > +typedef LONG(APIENTRY* PGETDISPLAYCONFIG_BUFFERSIZES)(UINT32, UINT32*,
> > UINT32*);
> > +typedef LONG(APIENTRY* PQUERYDISPLAYCONFIG)(UINT32, UINT32*,
> > DISPLAYCONFIG_PATH_INFO*, UINT32*,
> > + DISPLAYCONFIG_MODE_INFO*,
> > DISPLAYCONFIG_TOPOLOGY_ID*);
> > +typedef LONG(APIENTRY* PSETDISPLAYCONFIG)(UINT32,
> DISPLAYCONFIG_PATH_INFO*,
> > UINT32,
> > + DISPLAYCONFIG_MODE_INFO*,
> UINT32);
> > +
> > +class CCD {
> > +public:
> > + CCD();
> > + ~CCD();
> > +
> > + bool query_display_config();
> > + bool set_display_config();
> > + bool update_mode_position(LPCTSTR device_name, DEVMODE* dev_mode);
> > + bool update_mode_size(LPCTSTR DeviceNmae, DEVMODE* dev_mode);
> > + void update_detached_primary_state(LPCTSTR device_name,
> > DISPLAYCONFIG_PATH_INFO * path_info);
> > + bool set_path_state(LPCTSTR device_name, MONITOR_STATE state);
> > + bool is_attached(LPCTSTR device_name);
> > + bool is_active_path(DISPLAYCONFIG_PATH_INFO * path);
> > + LONG error() { return _error; }
> > + DISPLAYCONFIG_MODE_INFO* get_active_mode(LPCTSTR device_name, bool
> > return_on_error);
> > + DISPLAYCONFIG_PATH_INFO* get_device_path(LPCTSTR device_name, bool
> > bActive);
> > + bool verify_primary_position();
> > + void debug_print_config(const char* prefix = NULL);
> > +
> > +private:
> > + bool load_api();
> > + bool get_config_buffers();
> > + void free_config_buffers();
> > + bool is_device_path(LPCTSTR device_name, DISPLAYCONFIG_PATH_INFO*
> path);
> > + bool get_device_name_config(DISPLAYCONFIG_PATH_INFO* path, LPCTSTR
> > dev_name);
> > +
> > + //CCD API stuff
> > + UINT32 _NumPathElements;
> > + UINT32 _NumModeElements;
> > + DISPLAYCONFIG_PATH_INFO* _pPathInfo;
> > + DISPLAYCONFIG_MODE_INFO* _pModeInfo;
> > +
> > + //CCD API function pointers
> > + PDISPLAYCONFIG_GETDEVICEINFO _pfnGetDeviceInfo;
> > + PGETDISPLAYCONFIG_BUFFERSIZES _pfnGetDisplayConfigBufferSizes;
> > + PQUERYDISPLAYCONFIG _pfnQueryDisplayConfig;
> > + PSETDISPLAYCONFIG _pfnSetDisplayConfig;
> > +
> > + LONG _error;
> > + bool _primary_detached;
> > + PATH_STATE _path_state;
> > +};
> > +
> > +#endif
> > \ No newline at end of file
>
> Frediano
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160804/8845dbf8/attachment-0001.html>
More information about the Spice-devel
mailing list