[Spice-devel] [usbredir v2] usbredirhost: fix leak on error
Pavel Grunt
pgrunt at redhat.com
Thu Aug 4 12:33:26 UTC 2016
Ack
On Thu, 2016-08-04 at 14:15 +0200, Victor Toso wrote:
> Pointed by coverity:
> 17. usbredir-0.7.1/usbredirhost/usbredirhost.c:2306: leaked_storage:
> Returning without freeing "data" leaks the storage that it points to.
> # 2304|
> # usbredirhost_bulk_packet_complete(transfer->transfer);
> # 2305| }
> # 2306|-> }
> # 2307|
> # 2308| static void usbredirhost_iso_packet(void *priv, uint64_t
> # id,
> ---
> usbredirhost/usbredirhost.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/usbredirhost.c
> index 857e821..a6bf8b3 100644
> --- a/usbredirhost/usbredirhost.c
> +++ b/usbredirhost/usbredirhost.c
> @@ -2280,6 +2280,7 @@ static void usbredirhost_bulk_packet(void *priv,
> uint64_t id,
> transfer, BULK_TIMEOUT);
> #else
> r = LIBUSB_ERROR_INVALID_PARAM;
> + free(data);
> goto error;
> #endif
> } else {
More information about the Spice-devel
mailing list