[Spice-devel] [PATCH] spice-guest-tools: Include spice-webdavd installer

[Victor Toso]

Hi,

On Thu, Aug 04, 2016 at 02:16:42AM +0300, Visarion Alexandru wrote:
> From: Visarion Alexandru <viorel.visarion at gmail.com>
> 
> spice-webdavd is a very useful tool to have in a guest machine, as
> more and more clients are implementing shared folders and need it to
> be installed in their guest machines.
> 
> Let's do our part to make shared folders an out-of-th- box feature
> and include spice-webdavd in spice-guest-tools.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=94215

Have you had any issues on Win7 and up while transferring big files?
If we are going to have spice-webdavd on guest-tools I wonder if we
should also change the registry key [0] as pointed by Lukas in the
fdo#96223 [1]

[0] HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\WebClient\Parameters
[1] https://bugs.freedesktop.org/show_bug.cgi?id=96223

Cheers,
  toso

> ---
>  win-guest-tools.nsis | 7 +++++++
>  1 file changed, 7 insertions(+)
>  mode change 100644 => 100755 win-guest-tools.nsis
> 
> diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
> old mode 100644
> new mode 100755
> index 591b806..05c7995
> --- a/win-guest-tools.nsis
> +++ b/win-guest-tools.nsis
> @@ -120,9 +120,14 @@ Section "install"
>    SetOutPath "$INSTDIR\32"
>    File "bin/vdagent_x86/vdagent.exe"
>    File "bin/vdagent_x86/vdservice.exe"
> +  File "bin/webdav/spice-webdavd.msi"
> +  ExecWait '"msiexec" /i "$INSTDIR\32\spice-webdavd.msi"'
> +
>    SetOutPath "$INSTDIR\64"
>    File "bin/vdagent_x64/vdagent.exe"
>    File "bin/vdagent_x64/vdservice.exe"
> +  File "bin/webdav/spice-webdavd.msi"
> +  ExecWait '"msiexec" /i "$INSTDIR\64\spice-webdavd.msi"'
>  
>    SetOutPath "$INSTDIR\drivers"
>    File /r drivers/virtio/
> @@ -227,9 +232,11 @@ Section "Uninstall"
>    Delete /rebootok "$INSTDIR\Uninstall ${FILENAME}.exe"
>    Delete /rebootok "$INSTDIR\32\vdagent.exe"
>    Delete /rebootok "$INSTDIR\32\vdservice.exe"
> +  Delete /rebootok "$INSTDIR\32\spice-webdavd.msi"
>    RMDir /rebootok "$INSTDIR\32"
>    Delete /rebootok "$INSTDIR\64\vdagent.exe"
>    Delete /rebootok "$INSTDIR\64\vdservice.exe"
> +  Delete /rebootok "$INSTDIR\64\spice-webdavd.msi"
>    RMDir /rebootok "$INSTDIR\64"
>    RMDir /rebootok /r "$INSTDIR\drivers"
>  !ifdef OVIRT
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel