[Spice-devel] [PATCH win-vdagent] Adding ioctl operation to update Vdagent state

[Sameeh Jubran]

Hi,

NOTE: Only after adding "vmport=off" to "-machine" in the qemu command the
"mouse toggle" feature appeared in Spicy window.

After retesting the mouse mode toggle correctly, turns out that the patch
DOES NOT change the behaviour before applying this patch,
The mouse is visible and the mouse is "stuck" in the middle of the screen,
which is exactly the bug that Victor had described.

On Mon, Aug 8, 2016 at 3:23 PM, Victor Toso <lists at victortoso.com> wrote:

> Hi,
>
> On Mon, Aug 08, 2016 at 10:55:01AM +0300, Dmitry Fleytman wrote:
> > >> After testing this patch with spicy it turns out that the mouse is
> > >> always in client mode as long as vdagent is running.
>
> That's weird, I just tested here with spicy (upstream) on windows 7 with
> spice-guest-tools installed and the mouse-mode toggle works fine. I can
> see in the bottom changing from "mouse: client, agent: yes" to
> "mouse: server, agent: yes".
>
> There is a bug when you switch to serve-mode that when you click the
> mouse goes to upper-left position but the guest grabs the mouse after
> two or three clicks. AFAIR, someone was working on this.
>
> > >> However this behaviour is the same as the one prior to this patch
> > >> which means that this patch doesn't change the current behaviour of
> > >> the mouse mode.
>
> > >
> > > That is this patch is useless ??
> >
> > Hi Frediano,
>
> > I think Sameeh means that he did not succeed to switch
> > mouse mode to “server” using spicy and because of that he
> > was unable to verify that this patch does not introduce regressions.
> >
> > Do you have any idea why spicy does not switch mouse mode?
>
> So, with a spice-guest-tools-0.100 and spice-gtk v0.32 (or up) the
> toggle does not work. It could be something in the qemu cmdline.
> Marc-Andre said [0][1] that -machine ..vmport=off is necessary to make
> this work.
>
> [0] https://lists.freedesktop.org/archives/spice-devel/2015-
> November/023383.html
> [1] http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=208abbcbd7b7225
>
> Thanks for testing this!
>
> Cheers,
>   toso
>
> >
> > Thanks,
> > Dmitry
> >
> > >
> > > Frediano
> > >
> > >> On Thu, Aug 4, 2016 at 5:27 PM, Victor Toso < lists at victortoso.com >
> wrote:
> > >
> > >>> Hi,
> > >>
> > >
> > >>> On Thu, Aug 04, 2016 at 05:07:35PM +0300, Dmitry Fleytman wrote:
> > >>
> > >>>>>>> On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
> > >>
> > >>>>>>>> Hi Victor,
> > >>
> > >>>>>>>>
> > >>
> > >>>>>>>> How do we configure server mouse with VDAgent running?
> > >>
> > >>>>>>>
> > >>
> > >>>>>>> You mean the host/VM configuration? What I mean by my question is
> > >>>>>>> that
> > >>
> > >>>>>>> we can send a SpiceMsgcMainMouseModeRequest from client to change
> > >>>>>>> mouse
> > >>
> > >>>>>>> mode and I would like to know if that would still be possible
> with
> > >>>>>>> this
> > >>
> > >>>>>>> patch.
> > >>
> > >>>>>>>
> > >>
> > >>>>>>> Check:
> > >>
> > >>>>>>> https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=
> 5f89a4df037f6a1f2
> > >>
> > >>>>>>
> > >>
> > >>>>>> I mean, is there any tool/command line switch that we can use to
> check
> > >>>>>> this case?
> > >>
> > >>>>>
> > >>
> > >>>>> Yes! spicy has a `toggle mouse mode` in the options (shift + F7)
> > >>
> > >>>>
> > >>
> > >>>> Cool, I did not know this.
> > >>
> > >>>> Is there pre-compiled spicy binary that we can use somewhere?
> > >>
> > >
> > >>> It is part of spice-gtk code base, on fedora you can find it on
> > >>
> > >>> spice-gtk-tools package. Not sure if this is distributed on mingw
> > >>
> > >>> packages for windows.
> > >>
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel at lists.freedesktop.org <mailto:Spice-devel at lists.
> freedesktop.org>
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel <
> https://lists.freedesktop.org/mailman/listinfo/spice-devel>
>
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>


-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160808/54525944/attachment-0001.html>