[Spice-devel] [PATCH spice-gtk] vmcstream: Do not disconnect cancellable in coroutine

[Victor Toso]

Hi,

On Mon, Aug 08, 2016 at 05:49:31PM +0200, Pavel Grunt wrote:
> It is disconnected when spice_vmc_input_stream_read_all_finish()
> is called.
>
> Silence many warnings appearing with webdav:
>  GLib-GObject-WARNING **: gsignal.c:2635: instance '0x7fe658015c40' has no handler with id '13555'

Yes!
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  src/vmcstream.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/vmcstream.c b/src/vmcstream.c
> index 09a296b..0634bce 100644
> --- a/src/vmcstream.c
> +++ b/src/vmcstream.c
> @@ -165,7 +165,6 @@ spice_vmc_input_stream_co_data(SpiceVmcInputStream *self,
>          cb_data->pos = self->pos;
>          g_idle_add(complete_in_idle_cb, cb_data);
>  
> -        g_cancellable_disconnect(g_task_get_cancellable(self->task), self->cancel_id);
>          g_clear_object(&self->task);
>      }
>  
> -- 
> 2.9.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel