[Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

[Sameeh Jubran]

On Mon, Aug 8, 2016 at 6:47 PM, Frediano Ziglio <fziglio at redhat.com> wrote:

> > An optimal solution to this would be that the driver knows somehow when
> > we are in a server mode and when we are in a client mode. However this
> > information isn't available in the driver nor in the vdagent.
>
> Could you explain why an optimal solution require this knowledge?
> Also "However this information isn't available in the driver nor in the
> vdagent."
> does not make sense to me. The vdagent is sending this information to the
> driver so this information is available in vdagent.
>

The current information the driver is getting is about Vdagent state
(running/off), When
Vdagent is running then the client mouse should be enabled and when Vdagent
is off
server mouse should be enabled. This is true for the typical use case of
Vdagent.
But this isn't exactly true all of the time, for example when running Spicy
along with Vdagent on
 and we send a command to change the mouse mode to server mode we get that
Vdagent state is on
and the mouse in server mode.


> Frediano
>
> > On Mon, Aug 8, 2016 at 6:33 PM, Christophe Fergeau < cfergeau at redhat.com
> >
> > wrote:
>
> > > On Mon, Aug 08, 2016 at 06:19:41PM +0300, Sameeh Jubran wrote:
> >
> > > > >
> >
> > > > This patch enables the driver to send move commands to the QXL device
> > > > when
> >
> > > > vdagent is off.
> >
> > > > This maybe the reason you are not getting any move commands.
> >
>
> > > But don't we have exactly the same issue with a fedora guest or a win7-
> >
> > > guest? I've observed the same with a Fedora guest at least.
> >
> > > Also I don't think there is a strict equivalence between vdagent is
> >
> > > running and mouse is in server mode, so if we were to change this at
> the
> >
> > > agent level, are we going to fix all cases?
> >
>
> > > Christophe
> >
>
> > --
> > Respectfully,
> > Sameeh Jubran
> > Linkedin
> > Junior Software Engineer @ Daynix .
>
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160808/6e22c9c2/attachment.html>