[Spice-devel] [PATCH] Fix swprintf_s call under MingW

Victor Toso lists at victortoso.com
Wed Aug 10 08:52:03 UTC 2016


Hi,

On Wed, Aug 10, 2016 at 03:28:46AM -0400, Frediano Ziglio wrote:
> > 
> > For some reason this call does not behave correctly.
> > This was causing vdservice to fail to run the agent if compiled
> > with MingW.
> > 
>
> I tested with Windows 7 but I didn't manage to test with
> Windows XP. Can somebody test it with Windows XP ?

Just to keep info shared here, this does not works on Windows XP

>
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  common/vdcommon.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/common/vdcommon.h b/common/vdcommon.h
> > index 93bb673..bc8ce33 100644
> > --- a/common/vdcommon.h
> > +++ b/common/vdcommon.h
> > @@ -62,8 +62,6 @@ typedef CRITICAL_SECTION mutex_t;
> >   * those functions are not required to be in that dll on the guest.
> >   */
> >  #ifdef OLDMSVCRT
> > -#define swprintf_s(buf, sz, format...) swprintf(buf, format)
> > -
> >  #ifndef _ftime_s
> >  #define _ftime_s(timeb) _ftime(timeb)
> >  #endif
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list