[Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

[Francois Gouget]

On Thu, 11 Aug 2016, Daniel P. Berrange wrote:

> On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote:
> > 
> > The following patch broke compilation of xf86-video-qxl:
> > 
> > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb
> > Author: Christophe Fergeau <cfergeau at redhat.com>
> > Date:   Thu Mar 5 15:28:22 2015 +0100
> > 
> >     Mark unused public API methods/code as deprecated
> >     
> >     Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
> > 
> > 
> > The reason is it introduces a #include <glib.h> in spice-server.h which 
> > is a *public* header! This means any application that needs to include 
> > spice-server.h, like xf86-video-qxl, must now check for GLib even if 
> > they don't use it, like xf86-video-qxl.
> 
> They shouldn't have to check for it explicitly. The spice-server.pc
> pkgconfig file should have been updated in that commit so that glib-2.0
> is listed under "Requires" instead of "Requires.private", then applications
> using spice-server would not have broken, as pkg-config would have just
> "done the right thing" and automatically added -I/path/to/glib/headers.

Even so, while being Spice tradition, the naming conflicts and code 
duplication should be fixed. So I think my patchset still stands and 
removing the need for this glib.h include is a nice side benefit.

-- 
Francois Gouget <fgouget at codeweavers.com>