[Spice-devel] [PATCH spice-gtk] Do not require epoxy for Windows

[Frediano Ziglio]

> 
> On Mon, 2016-08-15 at 04:19 -0400, Frediano Ziglio wrote:
> > > 
> > > ---
> > >  configure.ac | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index 16d946b..a2b6525 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -135,6 +135,9 @@ AC_SUBST([GTK_REQUIRED])
> > >  AM_CONDITIONAL([WITH_GTK],[test "$with_gtk" != "no"])
> > >  
> > >  AS_IF([test "x$with_gtk" != "xno"],

OT: does it make sense to have spice-gtk without gtk?

> > > +      [AS_IF([test "x$os_win32" = "xyes"],
> > > +             [PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED)],
> > > +             [PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED epoxy)])]
> > >        [PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED epoxy)]
> > 
> > Should not this line be removed replaced with the above new ones?
> yes, sorry
> > 
> > > 
> > >        [GTK_CFLAGS="$GTK_CFLAGS
> > >        -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION \
> > >                                 -
> > > DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION"])
> > 
> > OT: Why was compiling for me under Windows ?
> Do you mean with this patch ? It seems that the second
> PKG_CHECK_MODULES(GTK..
> is ignored.
> 

I mean that for Windows it compile even without this patch
(at least using MingW)

> Pavel

Frediano