[Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

[Dmitry Fleytman]

Sent from my iPhone

> On 16 Aug 2016, at 13:30, Sameeh Jubran <sameeh at daynix.com> wrote:
> 
> 
>> On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>> >
>> > This patch defines the structures of ioctls that are used between
>> > win-vdagent and the qxl-wddm-dod driver.
>> >
>> > Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
>> > ---
>> >  spice/qxl_windows.h | 16 ++++++++++++----
>> >  1 file changed, 12 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h
>> > index bc2ceff..c4776d4 100644
>> > --- a/spice/qxl_windows.h
>> > +++ b/spice/qxl_windows.h
>> > @@ -2,20 +2,28 @@
>> >  #define _H_QXL_WINDOWS
>> >
>> >  #include <spice/types.h>
>> > -
>> > +#include <spice/qxl_dev.h>
>> >  #include <spice/start-packed.h>
>> >
>> >  enum {
>> >      QXL_ESCAPE_SET_CUSTOM_DISPLAY = 0x10001,
>> > -    QXL_ESCAPE_MONITOR_CONFIG
>> > +    QXL_ESCAPE_MONITOR_CONFIG,
>> > +    QXL_ESCAPE_VDAGENT_RUNNING
>> 
>> Didn't we decide to remove this?
> We can't remove this unless there is a good working alternative. We use those
> enums when calling this function https://msdn.microsoft.com/en-us/library/windows/desktop/dd162708%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396

I think QXL_ESCAPE_VDAGENT_RUNNING is not used indeed since it was decided to rework those patches.

Other entries are used.


> 
>  
>> 
>> >  };
>> >
>> > -typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {
>> > +struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {
>> >      uint32_t xres;
>> >      uint32_t yres;
>> >      uint32_t bpp;
>> > -} QXLEscapeSetCustomDisplay;
>> > +};
>> 
>> API change here.
> why? only removed unneeded typedef. 
>> 
>> >
>> > +struct SPICE_ATTR_PACKED QXL_ESCAPE {
>> > +    uint32_t ioctl;
>> > +    union {
>> > +        QXLEscapeSetCustomDisplay custom_display;
>> > +        QXLHead monitor_config;
>> > +    };
>> > +};
>> >  #include <spice/end-packed.h>
>> >
>> >  #endif /* _H_QXL_WINDOWS */
>> 
>> Frediano
> 
> 
> 
> -- 
> Respectfully,
> Sameeh Jubran
> Linkedin
> Junior Software Engineer @ Daynix.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160816/14b08b33/attachment.html>