[Spice-devel] [PATCH libcacard] Do not fail, if the caller didn't pick up response from previous call

[Pavel Grunt]

On Tue, 2016-08-16 at 12:15 +0200, Jakub Jelen wrote:
> On 08/16/2016 11:11 AM, Marc-André Lureau wrote:
> > 
> > Hi
> > 
> > ----- Original Message -----
> > > 
> > > Hello all,
> > > cross-posting the originally opened pull request on github [1] (with
> > > attached patch):
> > > 
> > > During our testing of a new CAC driver in OpenSC, with this library, we
> > > encountered a problem with |libcacard| failing and the driver returning
> > > only a fraction of the requested objects.
> > > 
> > > The problem is that the Emulator wants to return the data (properly
> > > signalized by 61 (RESPONSE BYTES) in SW1), but this is ignored for some
> > > reason in some of our calls from OpenSC. The Emulator should not fail
> > > hard for the next independent request, rather silently drop the buffer
> > > and serve the ongoing APDU request (I would left for consideration to
> > > somehow log such problem).
> > > 
> > > Patch was successfully tested on Fedora 24 host and solves our problem
> > > (though we worked around the problem already in the driver too).
> > > 
> > > [1] https://github.com/SPICE/libcacard/pull/1
> > ack, and pushed
> > 
> > Please next time, use git send-email (with the default inline patch
> > attachment)
> Thanks,
> I would do that, but the guidelines, talk about "format-patch" [1] and 
> not "send-email", which was the source of the confusion:
> 
>  > The patch was prepared using git format-patch
> 
> If the send-email was intended, it should be mentioned explicitly.

Thanks for the suggestion, fixed

Pavel

> 
> [1] http://www.spice-space.org/developers.html
> 
> Regards,
>