[Spice-devel] [PATCH spice-protocol v2] Add ioctls structures to qxl_windows.h

[Daniel P. Berrange]

On Tue, Aug 16, 2016 at 03:58:50PM +0300, Sameeh Jubran wrote:
> This patch defines the structures of ioctls that are used between
> win-vdagent and the qxl-wddm-dod driver.
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> ---
>  spice/qxl_windows.h | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h
> index bc2ceff..89aeac9 100644
> --- a/spice/qxl_windows.h
> +++ b/spice/qxl_windows.h
> @@ -2,7 +2,7 @@
>  #define _H_QXL_WINDOWS
>  
>  #include <spice/types.h>
> -
> +#include <spice/qxl_dev.h>
>  #include <spice/start-packed.h>
>  
>  enum {
> @@ -11,11 +11,18 @@ enum {
>  };
>  
>  typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {
> -    uint32_t xres;
> -    uint32_t yres;
> -    uint32_t bpp;
> +    uint32_t _xres;
> +    uint32_t _yres;
> +    uint32_t _bpp;
>  } QXLEscapeSetCustomDisplay;

Renaming fields in structs breaks API for any app already using the
struct in previous releases of spice-protocol

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|