[Spice-devel] [PATCH qxl-wddm-dod 02/26] Add delete operator

Sameeh Jubran sameeh at daynix.com
Wed Aug 17 13:11:15 UTC 2016


Yes it is a typo, the issue is with the declaration, it should be ::delete.

Thanks for pointing that :)

On Tue, Aug 16, 2016 at 6:42 PM, Frediano Ziglio <fziglio at redhat.com> wrote:

> >
> > Based on a patch by Sandy Stutsman <sstutsma at redhat.com>
> >
> > Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> > ---
> >  qxldod/BaseObject.cpp | 11 +++++++++++
> >  qxldod/BaseObject.h   |  1 +
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/qxldod/BaseObject.cpp b/qxldod/BaseObject.cpp
> > index ac270fd..a93c040 100755
> > --- a/qxldod/BaseObject.cpp
> > +++ b/qxldod/BaseObject.cpp
> > @@ -70,3 +70,14 @@ void __cdecl operator delete[](void* pObject)
> >          ExFreePool(pObject);
> >      }
> >  }
> > +
> > +void __cdecl operator delete(void *pObject, size_t s)
> > +{
> > +    PAGED_CODE();
> > +
> > +    UNREFERENCED_PARAMETER(s);
> > +
> > +    if (pObject != NULL) {
> > +        ExFreePool(pObject);
> > +    }
> > +}
> > diff --git a/qxldod/BaseObject.h b/qxldod/BaseObject.h
> > index 66e66e4..94bd163 100755
> > --- a/qxldod/BaseObject.h
> > +++ b/qxldod/BaseObject.h
> > @@ -57,3 +57,4 @@ _When_((PoolType & NonPagedPoolMustSucceed) != 0,
> >  void* __cdecl operator new[](size_t Size, POOL_TYPE PoolType =
> PagedPool);
> >  void  __cdecl operator delete(void* pObject);
> >  void  __cdecl operator delete[](void* pObject);
> > +void  __cdecl operator delete[](void *pObject, size_t s);
>
> The declaration is about ::delete[] but the definition is about ::delete.
> Is it a typo?
>
> Frediano
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160817/4d248405/attachment-0001.html>


More information about the Spice-devel mailing list