[Spice-devel] [PATCH] Add missing libX11 reference to build system

[Ian Stakenvicius]

On 18/08/16 04:15 AM, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
>> GTK on its own is not enough to ensure libX11 is properly linked with
>> libspice-client-gtk.  This patch adds X11_LIBS to SPICE_GTK_LIBADD_COMMON
>> (and X11_CFLAGS to a relevant section as well) in src/Makefile.am, and
>> performs an approriate pkg-config based check to determine the correct
>> values in configure.ac when not building for win32 or quartz.
>>
> 
> I would check it whenever the header is present (since the code will compile with x11 in this case)
> 
> AC_CHECK_HEADERS([X11/XKBlib.h], [PKG_CHECK_MODULES(X11, x11)])
> 

I didn't go into the code itself -- is libX11 only needed at link time
for functions/symbols coming from XKBlib.h ?

./configure should be fatal about libX11 not being found for any case
were libX11 is needed, and the AC_CHECK_HEADERS() check won't make it
be fatal just because the header is missing.  I guess I'll go through
the code and confirm that if XKBLib.h is missing then libX11 isn't a
link-time dep.



>> For more info see http://bugs.gentoo.org/585118
>>
>> Closes: https://github.com/SPICE/spice-gtk/pull/3
> 
> I don't think this brings anything valuable, github is just a mirror.

It auto-closes the PR on github once the commit is pushed to the
primary repo (and github syncs up), meaning you don't have to actually
touch github yourself.  Not that there's any discussion over there on
this PR, but if there were then this URL also provides a quick way to
reference it within the commit log and when looking at it on this list.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160818/61b4b186/attachment.sig>