[Spice-devel] [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

[Frediano Ziglio]

> 
> On Thu, 18 Aug 2016, Frediano Ziglio wrote:
> 
> > > 
> > > This makes it consistent with the other channel-display functions.
> > > 
> > > Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> > > ---
> > > 
> > > This patch makes sense on its own and can be applied even if the
> > > other two in the series are not.
> > > 
> > > 
> > 
> > I prefer the actual version.
> 
> Why?
> 
> IMHO it makes no sense to cast a SpiceChannel* to a DisplayChannel* when
> calling display_update_stream_report() only to cast it back, twice, to a
> SpiceChannel* inside that function.
> 

Because an apple is a fruit but a fruit is not an apple.

Frediano